feat: TCM-6606 add localeId and certificate attachment types to attachments-api - #141
Open
shoffman-smartling wants to merge 1 commit into
Open
feat: TCM-6606 add localeId and certificate attachment types to attachments-api#141shoffman-smartling wants to merge 1 commit into
shoffman-smartling wants to merge 1 commit into
Conversation
…hments-api Adds GLOSSARIES, TRANSLATION_CERTIFICATE_BUNDLE, and LOCALE_TRANSLATION_CERTIFICATE to AttachmentType, matching attachment-service's own canonical enum values. Adds a localeId field to AttachmentPTO and AttachmentUploadPTO so callers can associate an uploaded attachment with a specific job locale, as required for the two new certificate types. Also adds AttachmentType.toUrlSegment(), which hyphenates multi-word type names (e.g. translation-certificate-bundle) matching attachment-service's own URL routing convention, since name().toLowerCase() alone produces an incorrect underscore-separated segment for these new values.
AlexanderNovak
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GLOSSARIES,TRANSLATION_CERTIFICATE_BUNDLE, andLOCALE_TRANSLATION_CERTIFICATEtoAttachmentType, matching attachment-service's own canonical enum valueslocaleIdfield toAttachmentPTOandAttachmentUploadPTOso callers can associate an uploaded attachment with a specific job locale, needed for the two new certificate typesAttachmentType.toUrlSegment(), which hyphenates multi-word type names (e.g.translation-certificate-bundle) to match attachment-service's own URL routing convention, sincename().toLowerCase()alone produces an incorrect underscore-separated segment for these new valuesTracked in TCM-6606.
Test plan
./mvnw -pl smartling-attachments-api -am testpasses (6/6 tests inAttachmentsApiTest, including 2 new tests covering the wire format and enum values)