egl: Support ANGLE EGL platform on winit Wayland - #1082
Merged
Merged
Conversation
For this to work I also had to modify `LIB` to point to the `libEGL.so` from ANGLE. And set `VK_ICD_FILENAMES`, because naturally it wasn't working with Nvidia drivers, but was with Intel. This uses Vulkan. It seems ANGLE only provides the Wayland platform with Vulkan. This then runs, but errors with "Depth/stencil buffer format combination not allowed for blit." It seems it needs to use `DEPTH24_STENCIL8`. Presumably that's what the default framebuffer is using?
Unlike Wayland, X11 works on the OpenGL backend of ANGLE. But then `GL_OES_EGL_image_external` isn't available. So we need to use Vulkan here too.
Drakulix
reviewed
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this to work I also had to modify
LIBto point to thelibEGL.sofrom ANGLE. And setVK_ICD_FILENAMES, because naturally it wasn't working with Nvidia drivers, but was with Intel.This uses Vulkan. It seems ANGLE only provides the Wayland platform with Vulkan.
This then runs, but errors with "Depth/stencil buffer format combination not allowed for blit." It seems it needs to use
DEPTH24_STENCIL8. Presumably that's what the default framebuffer is using?