Bundle gg 208, and keep its download dots off stdout - #52
Merged
Merged
Conversation
The bundled wrapper is gg renamed, and it had drifted: 199 at the repo root, 183 under skills/, so installing the skill from the repo got a gg 25 versions older than the one the README hands out. Both are 208 now. gg 208 is the first that can be told to stop printing download progress on stdout, which matters here because that is the same pipe an agent's review comes back on: on a cold cache the captured output began "0%.........100%" and postmortemthis printed it as part of what the agent said. Verified against a scratch GG_CACHE_DIR, dots before and a bare version line after. GG_HIDE_DOWNLOAD_PROGRESS goes on the review command only - `login` runs on an inherited terminal and wants its progress, and nothing parses that one. gg 200 also fixed `gg update <alias>` looking tools up by cache name, so the note on gg_tool() saying `update antigravity` finds nothing is no longer true. Keep the cache name anyway: it is the one that works on every gg, new or old.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled wrapper is gg renamed, and it had drifted: 199 at the repo root, 183 under skills/, so installing the skill from the repo got a gg 25 versions older than the one the README hands out. Both are 208 now.
gg 208 is the first that can be told to stop printing download progress on stdout, which matters here because that is the same pipe an agent's review comes back on: on a cold cache the captured output began "0%.........100%" and postmortemthis printed it as part of what the agent said. Verified against a scratch GG_CACHE_DIR, dots before and a bare version line after. GG_HIDE_DOWNLOAD_PROGRESS goes on the review command only -
loginruns on an inherited terminal and wants its progress, and nothing parses that one.gg 200 also fixed
gg update <alias>looking tools up by cache name, so the note on gg_tool() sayingupdate antigravityfinds nothing is no longer true. Keep the cache name anyway: it is the one that works on every gg, new or old.