Repository navigation
Lesly/recipe api endpoints - #55
Conversation
Solian21
left a comment
There was a problem hiding this comment.
I think one of the biggest things is the CI test that is currently failing. I would also say looking at the comment about NotBlank that way we can assure that our recipes have names to them.
| @Size(min = 1, message = "Name must not be blank") | ||
| String name, | ||
|
|
||
| Set<Long> ingredientIds, |
There was a problem hiding this comment.
Same review at RecipeCreate
There was a problem hiding this comment.
This still appears unresolved. Using ingredientIds here is fine, but docs/openapi.yaml still defines ingredients as an array of objects in both RecipeCreate and RecipePatch. Please update those request schemas to match the code before resolving this comment.
Solian21
left a comment
There was a problem hiding this comment.
Awesome this looks good to be
| @Size(min = 1, message = "Name must not be blank") | ||
| String name, | ||
|
|
||
| Set<Long> ingredientIds, |
There was a problem hiding this comment.
This still appears unresolved. Using ingredientIds here is fine, but docs/openapi.yaml still defines ingredients as an array of objects in both RecipeCreate and RecipePatch. Please update those request schemas to match the code before resolving this comment.
…d the service tests to use Jackson 3's
annabelleb20
left a comment
There was a problem hiding this comment.
This looks really great!
Closes #52 and Closes #44
What changed
RecipeCreateRecipePatchRecipeResponseRecipeRepositoryRecipeServiceRecipeControllerHow I tested it
./gradlew test./gradlew clean buildReviewers
2 approving teammates who are not the author (1 for a team of 3).