Skip to content

Carlos/o auth setup - #56

Merged
Solian21 merged 4 commits into
mainfrom
Carlos/OAuth_Setup
Oct 20, 2026
Merged

Solian21 merged 4 commits into
mainfrom
Carlos/OAuth_Setup

Conversation

@Solian21

Copy link
Copy Markdown
Owner

Closes #20

What changed

  • Added so that on the first sign in the user is created and added to our neondb

How I tested it

  • Unit tests pass locally
  • If the API contract changed, docs/openapi.yaml is updated and lints clean (npx @redocly/cli lint docs/openapi.yaml)

Reviewers

2 approving teammates who are not the author (1 for a team of 3).

… Carlos/OAuth_Setup

This is the most up to date version of the code.
… Carlos/OAuth_Setup

Making my code up to date

@annabelleb20 annabelleb20 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

@leslyVillanueva1020 leslyVillanueva1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! i see getUserByEmail return an existing user or creates a new user during the first OAuth sign in and the test verifies that a missing user is saved with the expected email, display name, and user role

@Solian21
Solian21 merged commit de5cece into main Oct 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

As a developer, I want to set up OAuth so that we can make sure it's set up correctly early on.

3 participants