Repository navigation
Conversation
Member
|
Does this change require modification to the viewer? |
…r advanced configuration
Contributor
Author
Change by itself doesnt break viewer, but it's needed to show new info. |
Comment on lines
+419
to
+423
| catch (Exception e) | ||
| { | ||
| DebugLog.LogEvent($"Failed to read advanced configuration for network adapter: {adapter["Description"]}", DebugLog.Region.Networking, DebugLog.EventType.ERROR); | ||
| DebugLog.LogEvent($"{e}", DebugLog.Region.Networking, DebugLog.EventType.ERROR); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR retrieves advanced configuration options from registry for installed network adapters. Some of those options could be changed by user, network optimizer tool or tweak, which may cause connectivity problems, for example link autonegotiation or dual band mode for Wi-Fi.
Most of physical adapters like Ethernet and Wi-Fi will have a list of settings. Each driver will have it's own different list, for example list in Qualcomm NICs will be different than in Intel or MediaTek NICs. Software adapters like VPNs wont have those settings.
Example: