Skip to content

Modify Settings into singleton, graphical update for settings switches - #117

Open
Adam1213 wants to merge 6 commits into
Spec-ify:mainfrom
Adam1213:settings-wpf
Open

Adam1213 wants to merge 6 commits into
Spec-ify:mainfrom
Adam1213:settings-wpf

Conversation

@Adam1213

Copy link
Copy Markdown
Contributor

This PR changes how Settings class works with WPF. Settings is now a singleton instead of static class and properties change using bindings instead of events. Setting switches got reworked to deduplicate code and ease style changes.

From other changes:

  • Onedrive account redaction is now completely merged with username redaction.
  • Edited how Onedrive account is redacted, without need of exception handling and calling method again
  • Slight style changes like lower margins for settings switches, bolder font.
  • EnableDebug setting is now a property, with extra logic to exclude it from debug logs

May conflict with #114

@Adam1213

Copy link
Copy Markdown
Contributor Author

Also noting #116 , hack to serialize static class will no longer be needed.

@zleyyij

zleyyij commented Oct 20, 2026

Copy link
Copy Markdown
Member

@Adam1213 could you fix the merge conflict?

If you're busy, I can try my best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants