Create SortingAnalyzer object directly during create_sorting_analyzer#4705
Create SortingAnalyzer object directly during create_sorting_analyzer#4705ecobost wants to merge 4 commits into
Conversation
|
Another change I would propose is to drop saving sorting_provenance.json during SortingAnalyzer.create_binary_folder. create_binary_folder already saves the entire sorting object (including a provenance.json) in sorting/ so no need to save the provenance again with a diff name. |
I know ages ago we discussed dropping support for waveform extractors after a few versions of sorting analyzers, but then ultimately decided to maintain support to keep backward compatibility. What is the cost of just keeping this around to help with backward compatibility in general? I'm not saying we shouldn't listen to our own comments, but I tend to support backwards compatibility as much as possible. Especially since I've analyzed data with multiple versions of SI and would prefer that everything just work :) |
Three changes (separated in 3 commits):
Last one might be the more contentious change. I imagine the reloading during the creation was there to make sure everything could be reloaded fine but everything in the folder is already in memory during create_*() so there isn't really a need to save and reload them into memory, it seems more logical to create the SortingAnalyzer right away.
Closes #4410.