feat(phase-60): live-backend isolation for LOCOMO (60-01) - #49
Open
RichardHightower wants to merge 1 commit into
Open
feat(phase-60): live-backend isolation for LOCOMO (60-01)#49RichardHightower wants to merge 1 commit into
RichardHightower wants to merge 1 commit into
Conversation
Spawn one daemon per conversation (tempdir, free port, pid-file) so `--backend cli` no longer bleeds events across samples. Drain waits poll GetIndexCheckpoints instead of sleeping; results record isolation and drain_wait_ms. Sequence 0 now advances the BM25 checkpoint, and TeleportSearcher reloads so query sees indexer commits. CI job bench-cli-smoke runs the 1-conversation fixture against a spawned daemon. `--limit-questions` is ready for the 60-02 dry-run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 60-01 of v3.2 Prove It (#46).
--backend clino longer bleeds events across LOCOMO conversations.tempdir, free port,--pid-file)GetIndexCheckpoints(nothread::sleepstand-in)isolation: per-conversation daemonand per-conversationdrain_wait_ms--limit-questionsready for the 60-02 dry-runbench-cli-smokeruns the 1-conversation fixture against a spawned daemonTwo bugs that would have made the live number 0.0:
Closes BENCH-10 / BENCH-11. Unblocks #39 (60-02, maintainer-owned).
Acceptance
memory-bench locomo --backend cli --scorer mock --dataset benchmarks/fixtures/locomo-smoke.json→isolation: per-conversation daemon+drain_wait_mscli_isolated_daemons_do_not_bleed(underMEMORY_BENCH_LIVE=1)bench-cli-smokeaddedstd::thread::sleepin the cli-backend path (poll_pauseusesrecv_timeout)Verified locally: locomo smoke
drain_wait_ms=50390, bleed test 65s, two daemons, no cross-talk.Test plan
cargo fmt --all -- --checkcargo clippy -p memory-bench -p memory-indexing --all-targets -- -D warningsbench-cli-smoke+ workspace test/clippy/doc