fix: TLS off-loopback; S3 NFR is rsync (0.3.1) - #2
Open
RichardHightower wants to merge 1 commit into
Open
Conversation
Non-loopback --bind without OKF_MCP_TLS_CERT/KEY is a startup error. Loopback may still bind bare. Low-latency NFR holds for rsync push; S3 end-to-end stays bounded by the consumer daemon's pull.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the 0.3.0 review on okf-plugin#74. Spec comments landed first.
TLS
Loopback (
127.0.0.1,::1,localhost) may bind bare. Any other bind requiresOKF_MCP_TLS_CERT+OKF_MCP_TLS_KEYor it is a startup error — same shape as the issuer check.0.0.0.0:8080without certs will not start.S3 latency
The low-latency NFR holds for rsync push. S3 end-to-end is still bounded by the consumer daemon's pull. Bucket notifications are a different transport and are not picked.
docs/S3.mdsays so.19 tests green. Version 0.3.1.