Skip to content

Bump local Spine dependencies and proofreading#199

Open
alexander-yevsyukov wants to merge 13 commits into
masterfrom
bump-local-deps
Open

Bump local Spine dependencies and proofreading#199
alexander-yevsyukov wants to merge 13 commits into
masterfrom
bump-local-deps

Conversation

@alexander-yevsyukov

@alexander-yevsyukov alexander-yevsyukov commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Routine Spine SDK maintenance for the time repository: refreshes the local
Spine dependency catalogue in buildSrc to the latest Artifact Registry
snapshots, adapts the codebase to the new core-jvm API, updates the config
submodule, and regenerates the dependency reports.

What changed

Local dependency refreshbuildSrc/src/main/kotlin/io/spine/dependency/local/

  • CoreJvm2.0.0-SNAPSHOT.522 (Artifact Registry tip)
  • Base.426, BaseTypes.224, Change.207, Compiler.063,
    Logging.423, ToolBase.404
  • Earlier on the branch: ModelCompiler, ProtoTap, Reflect, TestLib,
    Time, and Validation were refreshed to their current snapshots.
  • Secondary version constants that were pinned equal to their primary moved in
    lockstep: Base.versionForBuildScript, Compiler.fallbackDfVersion, and
    ToolBase.dogfoodingVersion.

Code adaptations to the new CoreJvm API

  • time/src/main/java/io/spine/time/Temporals.java
  • validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenOption.kt
  • time/src/test/kotlin/io/spine/time/DefaultValueConversionSpec.kt
  • Plus deprecation suppressions (each carrying a rationale comment naming the
    replacement API) and an ErrorProne fix.

Build

  • Force Jackson (build.gradle.kts, tests/build.gradle.kts).
  • Bump project version → 2.0.0-SNAPSHOT.250.

Infrastructure

  • Update the config submodule (pulls buildSrc/Gradle infra updates and
    relocates the dependency report from the repo root to docs/dependencies/).
  • Regenerate docs/dependencies/dependencies.md and docs/dependencies/pom.xml.

Proofreading (commit ebe7e412)

Since the branch already touched many files, a repository-wide proofread was
run in the same PR to avoid a second large documentation-only PR later. All 171
project-owned files (Java, Kotlin, Gradle Kotlin DSL, Protobuf, Markdown) were
swept against the English style catalog in
.agents/guidelines/english-style.md; 39 files changed.

Only prose inside comments and Markdown body text was edited. Recurring classes:

  • Articles — the largest group ("Obtains converter from Java Time" →
    "Obtains the converter…", "a ISO-8601" → "an ISO-8601").
  • Verb form in API summaries — "Prevent instantiation" → "Prevents
    instantiation" (7×), "Parse from" → "Parses from".
  • Restrictive "which" vs. "that" — applied only where no leave-alone guard
    matched; non-restrictive clauses untouched.
  • Subject–verb agreement — "The value of the field that are changing" →
    "…that is changing" (4× in time_change.proto).
  • Verb complementation — "This allows to write:" → "This allows writing:".
  • Genuine typos — "this point is time" → "this point in time" (21× in
    Temporal.java), "Coverts" → "Converts", "hanbdles" → "handles", "the the",
    "a a".

Ambiguous cases were reported rather than edited, per the catalog's "a missed
error is cheaper than a wrong fix" bias.

Verified mechanically: the proofread commit touches no executable line,
keeps every {@link} / {@code} / @see / [Symbol] reference
byte-identical, and adds no line over the 100-column limit. Copyright headers in
the touched files were refreshed by the repository's own PostToolUse hook.
./gradlew clean build dokkaGenerate passes with no unresolved-link warnings.

Reviewer notes

  • The large line-count delta (~7.5k deletions) is almost entirely the
    config-managed dependency-report relocation (root dependencies.md /
    pom.xml removed, regenerated under docs/dependencies/) together with the
    config submodule bump — not hand-written code. Per repo convention,
    config-distributed files are out of scope for review in a consumer repo.
  • All local Spine artifacts are snapshots, which is expected for the local
    dependency scope; they are moved together to avoid ABI drift across the SDK.
  • The final six local bumps were verified against the Spine Artifact Registry
    maven-metadata.xml — each is the latest available snapshot.

🤖 Generated with Claude Code

alexander-yevsyukov and others added 10 commits July 25, 2026 00:24
Both new `@Suppress("DEPRECATION")` annotations in `DefaultValueConversionSpec`
now carry a reason comment naming the replacement API, matching the file's
existing convention and `java-code-style.md` § "Suppressing warnings":

- `ZoneOffsets` is superseded by `ZoneIds`.
- `OffsetTimes` is superseded by `LocalTime` + `ZoneId`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 25, 2026 00:21
@alexander-yevsyukov alexander-yevsyukov self-assigned this Jul 25, 2026
@alexander-yevsyukov alexander-yevsyukov moved this to 🏗 In progress in v2.0 Jul 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Routine Spine SDK maintenance for the time repository: updates local Spine snapshot coordinates and aligns the repo with updated core-jvm APIs and refreshed build tooling/reporting.

Changes:

  • Bump project publish version to 2.0.0-SNAPSHOT.250 and refresh local Spine snapshot versions in buildSrc.
  • Adapt code/tests to updated Core JVM APIs (e.g., pattern matching + targeted deprecation suppressions).
  • Update build tooling: enforce Jackson BOM/artifacts more broadly, relocate/regenerate dependency reports, and extend buildSrc coverage/reporting infrastructure.

Reviewed changes

Copilot reviewed 140 out of 149 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version.gradle.kts Bumps publish version to .250.
validation/src/main/kotlin/io/spine/tools/time/validation/java/WhenOption.kt Removes no-longer-needed import for new API surface.
time/src/test/kotlin/io/spine/time/DefaultValueConversionSpec.kt Adds scoped deprecation suppressions with rationale.
time/src/main/java/io/spine/time/Temporals.java Modernizes instanceof handling for Timestamp.
tests/build.gradle.kts Forces Jackson DataFormat + BOM in test buildscript/configs.
pom.xml Removes root-level generated dependency report POM.
docs/dependencies/pom.xml Regenerated dependency report POM under docs/dependencies/.
docs/dependencies/dependencies.md Regenerated dependency/license report under docs/dependencies/.
buildSrc/src/main/resources/dokka/styles/custom-styles.css Copyright year update.
buildSrc/src/main/kotlin/write-manifest.gradle.kts Minor wording/grammar fixes in KDoc.
buildSrc/src/main/kotlin/uber-jar-module.gradle.kts Fixes typo (“fat JAR”) and modernizes task lookup (tasks.named).
buildSrc/src/main/kotlin/test-module.gradle.kts Copyright year update.
buildSrc/src/main/kotlin/Strings.kt Minor wording/grammar fix in KDoc.
buildSrc/src/main/kotlin/pmd-settings.gradle.kts Copyright year update.
buildSrc/src/main/kotlin/module-testing.gradle.kts Copyright year update + minor KDoc grammar.
buildSrc/src/main/kotlin/kmp-publish.gradle.kts Copyright year update.
buildSrc/src/main/kotlin/kmp-module.gradle.kts Cleans up KDoc wording and removes now-unneeded suppression.
buildSrc/src/main/kotlin/io/spine/gradle/testing/TestKitCoverage.kt Uses centralized Jacoco.agent coordinate + KDoc updates.
buildSrc/src/main/kotlin/io/spine/gradle/testing/SpineCompilerCoverage.kt New: captures JaCoCo exec data from forked Spine Compiler JavaExec tasks.
buildSrc/src/main/kotlin/io/spine/gradle/testing/Multiproject.kt Fixes typo (“dependent”).
buildSrc/src/main/kotlin/io/spine/gradle/testing/Logging.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/TaskName.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/StringExtensions.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/RunGradle.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/RunBuild.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/SpineLicense.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/ProjectMetadata.kt Refactors metadata extraction to explicit non-empty fallback logic.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/PomXmlWriter.kt Copyright year update + minor KDoc grammar.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/PomFormatting.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/ModuleDependency.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/MarkupExtensions.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/InceptionYear.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/pom/DependencyScope.kt Minor punctuation/grammar fix in comment.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/Template.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/Tasks.kt Copyright year update + minor grammar.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/ProjectDependencies.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/MarkdownReportRenderer.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/license/Configuration.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/report/coverage/SiblingCoverage.kt Exposes consumesCoverageBinaryReports() for cross-package reuse + KDoc update.
buildSrc/src/main/kotlin/io/spine/gradle/report/coverage/KoverConfig.kt Extends root Kover aggregation to include compiler-fork .exec data + deprecation fix.
buildSrc/src/main/kotlin/io/spine/gradle/repo/RepoSlug.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/repo/Credentials.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/publish/StandardJavaPublicationHandler.kt Copyright year update + minor grammar.
buildSrc/src/main/kotlin/io/spine/gradle/publish/SpinePublishing.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/publish/PublishingRepos.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/publish/PublishingExts.kt Minor grammar fix in KDoc/suppression comment.
buildSrc/src/main/kotlin/io/spine/gradle/publish/PublicationHandler.kt Minor punctuation fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/publish/ProtoExts.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/publish/CloudRepo.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/publish/CloudArtifactRegistry.kt Copyright year update + minor grammar fix.
buildSrc/src/main/kotlin/io/spine/gradle/ProjectExtensions.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javascript/task/Publish.kt Fixes typo (“NPM”).
buildSrc/src/main/kotlin/io/spine/gradle/javascript/task/IntegrationTest.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javascript/plugin/Protobuf.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javascript/plugin/McJs.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javascript/plugin/JsPlugins.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javascript/plugin/Idea.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javascript/JsExtension.kt Minor wording fixes (JavaScript, articles).
buildSrc/src/main/kotlin/io/spine/gradle/javascript/JsEnvironment.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javascript/JsContext.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/javadoc/JavadocTag.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/javadoc/JavadocConfig.kt Copyright year update + minor KDoc grammar/whitespace.
buildSrc/src/main/kotlin/io/spine/gradle/javadoc/ExcludeInternalDoclet.kt Minor wording fix (“fully qualified”).
buildSrc/src/main/kotlin/io/spine/gradle/javadoc/Encoding.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/javac/Javac.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/javac/ErrorProne.kt Copyright year update + hyphenation fix (“Command-line”).
buildSrc/src/main/kotlin/io/spine/gradle/java/Tasks.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/github/pages/UpdateGitHubPagesExtension.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/github/pages/UpdateGitHubPages.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/github/pages/Update.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/github/pages/AuthorEmail.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/git/UserInfo.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/git/Repository.kt Multiple wording fixes (“temporary”, “check out”, etc.).
buildSrc/src/main/kotlin/io/spine/gradle/git/Branch.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/dart/task/Publish.kt Minor grammar fixes in KDoc/comments.
buildSrc/src/main/kotlin/io/spine/gradle/dart/task/IntegrationTest.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/dart/task/DartTasks.kt Minor wording fix (“resulting”).
buildSrc/src/main/kotlin/io/spine/gradle/dart/task/Build.kt Minor grammar fixes (“command”, “compatibility”).
buildSrc/src/main/kotlin/io/spine/gradle/dart/plugin/Protobuf.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/dart/plugin/DartPlugins.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/dart/DartExtension.kt Minor wording/grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/dart/DartEnvironment.kt Minor wording/formatting fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/dart/DartContext.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/ConfigTester.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/io/spine/gradle/Clean.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/checkstyle/CheckStyleConfig.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/Build.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/gradle/base/Tasks.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/docs/MarkdownDocument.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/test/TestKitTruth.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/test/SystemLambda.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/test/OpenTest4J.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/test/Kover.kt Bumps Kover version to 0.9.9.
buildSrc/src/main/kotlin/io/spine/dependency/test/Kotest.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/test/Jacoco.kt Adds Jacoco.agent coordinate constant for -javaagent usage.
buildSrc/src/main/kotlin/io/spine/dependency/test/Hamcrest.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/test/AssertK.kt Copyright year update + punctuation fix.
buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt Bumps local Validation snapshot version.
buildSrc/src/main/kotlin/io/spine/dependency/local/ToolBase.kt Bumps ToolBase snapshot + aligns dogfooding version.
buildSrc/src/main/kotlin/io/spine/dependency/local/Time.kt Bumps local Time snapshot version.
buildSrc/src/main/kotlin/io/spine/dependency/local/TestLib.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/local/Spine.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/local/Reflect.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/local/ProtoTap.kt Minor grammar fix in suppression comment.
buildSrc/src/main/kotlin/io/spine/dependency/local/ModelCompiler.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/local/Logging.kt Bumps local Logging snapshot version.
buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvm.kt Bumps CoreJvm snapshot version (notably to .522).
buildSrc/src/main/kotlin/io/spine/dependency/local/Compiler.kt Bumps Compiler fallback versions + minor grammar.
buildSrc/src/main/kotlin/io/spine/dependency/local/Change.kt Bumps local Change snapshot version.
buildSrc/src/main/kotlin/io/spine/dependency/local/BaseTypes.kt Bumps local BaseTypes snapshot version.
buildSrc/src/main/kotlin/io/spine/dependency/local/Base.kt Bumps local Base snapshot + buildscript version.
buildSrc/src/main/kotlin/io/spine/dependency/lib/Slf4J.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/dependency/lib/Roaster.kt Fixes typo (“built”).
buildSrc/src/main/kotlin/io/spine/dependency/lib/Protobuf.kt Minor grammar fix in KDoc.
buildSrc/src/main/kotlin/io/spine/dependency/lib/KotlinX.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/lib/Klaxon.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/lib/JavaX.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/lib/JavaPoet.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/lib/JavaJwt.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/lib/Jackson.kt Bumps Jackson to 2.22.1 and exposes DataFormat modules/BOM usage.
buildSrc/src/main/kotlin/io/spine/dependency/lib/Coroutines.kt Fixes typo in link text (“project”).
buildSrc/src/main/kotlin/io/spine/dependency/lib/BouncyCastle.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/lib/Asm.kt Minor grammar fix in comment.
buildSrc/src/main/kotlin/io/spine/dependency/lib/AppEngine.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/lib/ApacheHttp.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/kotlinx/Serialization.kt Fixes spacing in KDoc.
buildSrc/src/main/kotlin/io/spine/dependency/kotlinx/KotlinX.kt Copyright year update.
buildSrc/src/main/kotlin/io/spine/dependency/Dependency.kt Fixes double-space in KDoc param description.
buildSrc/src/main/kotlin/io/spine/dependency/build/ErrorProne.kt Bumps Error Prone to 2.42.0 with Java 17 compatibility note.
buildSrc/src/main/kotlin/io/spine/dependency/boms/BomsPlugin.kt Fixes typo (“though”).
buildSrc/src/main/kotlin/io/spine/dependency/boms/Boms.kt Copyright year update.
buildSrc/src/main/kotlin/DokkaExts.kt Minor grammar fixes in KDoc.
buildSrc/src/main/kotlin/DocumentationSettings.kt Copyright year update.
buildSrc/src/main/kotlin/detekt-code-analysis.gradle.kts Minor grammar fixes in script comments/KDoc.
buildSrc/src/main/kotlin/DependencyResolution.kt Minor wording fix (“3rd-party”).
buildSrc/src/main/kotlin/config-tester.gradle.kts Minor grammar fix in comment.
buildSrc/src/main/kotlin/BuildSettings.kt Copyright year update.
buildSrc/src/main/kotlin/BuildExtensions.kt Minor grammar fixes in KDoc/comments.
buildSrc/settings.gradle.kts Copyright year update.
buildSrc/quality/checkstyle.xml Copyright year update.
buildSrc/quality/checkstyle-suppressions.xml Copyright year update.
buildSrc/build.gradle.kts Bumps Kover version and minor comment grammar.
build.gradle.kts Forces Jackson DataFormat + BOM; forces CoreJvm client artifact.
.idea/misc.xml Removes tracked IDE-local file.
.idea/live-templates/README.md Fixes spacing in instructions.
.gitignore Keeps .idea/misc.xml ignored; ignores Claude plans/local settings.
.claude/settings.json Configures Claude plans directory + extends allowed commands/skills.
Files not reviewed (1)
  • .idea/misc.xml: Generated file

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.39%. Comparing base (57d3dd9) to head (4340d3a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #199      +/-   ##
============================================
- Coverage     84.40%   84.39%   -0.02%     
  Complexity      306      306              
============================================
  Files            60       60              
  Lines          1103     1102       -1     
  Branches         46       46              
============================================
- Hits            931      930       -1     
  Misses          163      163              
  Partials          9        9              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sweep all 171 project-owned files (Java, Kotlin, Gradle Kotlin DSL, Protobuf,
and Markdown) against the English style catalog in
`.agents/guidelines/english-style.md`. Only prose inside comments and Markdown
body text was edited: 39 files changed.

The recurring error classes:

- Articles — the largest group, e.g. "Obtains converter from Java Time" ->
  "Obtains the converter...", and "a ISO-8601" -> "an ISO-8601".
- Verb form in API summaries — "Prevent instantiation" -> "Prevents
  instantiation" (7 occurrences), "Parse from" -> "Parses from".
- Restrictive "which" vs. "that" — applied only where no leave-alone guard
  matched; non-restrictive clauses were left untouched.
- Subject-verb agreement — "The value of the field that are changing" ->
  "... that is changing" (4 occurrences in `time_change.proto`).
- Verb complementation — "This allows to write:" -> "This allows writing:".
- Genuine typos — "this point is time" -> "this point in time" (21
  occurrences in `Temporal.java`), "Coverts" -> "Converts", "hanbdles" ->
  "handles", "the the", and "a a".

Ambiguous occurrences were reported rather than edited, per the catalog's
"a missed error is cheaper than a wrong fix" bias.

Verified that the change set touches no executable line, keeps every
`{@link}` / `{@code}` / `@see` / `[Symbol]` reference byte-identical, and adds
no line over the 100-column limit. Copyright headers in the touched files were
refreshed by the repository's own `PostToolUse` hook.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 25, 2026 00:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 178 out of 187 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • .idea/misc.xml: Generated file

Comment thread time/src/main/java/io/spine/time/TimeChanges.java
Comment thread time/src/main/proto/spine/time/time.proto Outdated
Two documentation fixes raised in review:

- `TimeChanges.of(OffsetDateTime, OffsetDateTime)` documented its arguments as
  "field values of offset time", copied from the `OffsetTimeChange` overload
  above it. The overload operates on `OffsetDateTime`, so the summary now reads
  "of offset date-time", matching the per-type wording the other overloads use
  ("local date", "local time", "offset time").

- The deprecation note on the `OffsetDateTime` message in `time.proto` was
  missing an auxiliary verb: "Usage history shown that ..." -> "Usage history
  has shown that ...". The proofread sweep had flagged this occurrence as
  ambiguous rather than guessing between "has shown" and "showed"; review
  settled it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 25, 2026 01:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 178 out of 187 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • .idea/misc.xml: Generated file

- `LocalDates.checkDate(int, Month, int)` listed the *failure* conditions under
  a "Verifies that:" heading, so the documentation stated the opposite of what
  the method checks: "the month is not in the range of `JANUARY` to `DECEMBER`"
  and "the day is less or equal zero or greater than can be in the month". The
  list now describes the conditions the method actually verifies.

- Three `Duration` extension functions in `DurationExts.kt` described their
  receiver as "the passed value", a leftover from the static `Durations2`
  helpers they delegate to. They now say "this duration".

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 25, 2026 01:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 178 out of 187 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • .idea/misc.xml: Generated file

@alexander-yevsyukov alexander-yevsyukov changed the title Bump local Spine dependencies Bump local Spine dependencies and proofreading Jul 25, 2026
@alexander-yevsyukov alexander-yevsyukov moved this from 🏗 In progress to In Review in v2.0 Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants