Repository navigation
chore(TODO): record declared LLM test coverage as the follow-up to #240 - #241
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one
TODOitem, the follow-up discussed on #240.What it records: replace
test_coverage.py's class-name → test-file mapping with a declared one. EachTestLLMBasesubclass setsllm_class = ..., and the coverage checks compare those declarations against the discovered clients. That deletes:if test_file_path.exists()skips.It also turns the "informational for now" inheritance check into a hard requirement.
Why it's a TODO and not a PR: upstream it's about 1–2 hours. But forks whose client tests don't subclass
TestLLMBasewill fail CI after syncing until they migrate, so forks should get notice before it lands.🤖 Generated with Claude Code