Skip to content

refactor: rename generate_conversations package to generate - #245

Merged
luca-belli merged 1 commit into
mainfrom
refactor/rename-generate-package
Oct 8, 2026
Merged

luca-belli merged 1 commit into
mainfrom
refactor/rename-generate-package

Conversation

@luca-belli

Copy link
Copy Markdown
Collaborator

Summary

Renames the generation package generate_conversations/ to generate/. docs/architecture.md already named this as the permanent name, and moving generate.py into legacy/ (#243) removed the clash with a root generate module.

  • git mv for the package and tests/unit/generate_conversations/ → tests/unit/generate/, so history follows the files
  • Updated imports and patch() targets in vera_cli/generate.py, legacy/generate.py, and tests. Shorter target strings let ruff collapse many with patch(...) blocks onto one line, which is most of the diff.
  • tests/unit/test_vera_cli.py: the thin-entry-point check now asserts vera.py has no import generate / from generate line. A plain substring check would always fail, because vera.py has a generate subcommand.
  • Docs: docs/architecture.md, AGENTS.md, .claude/agents/test-engineer.md. Added a CHANGELOG "Breaking / migration" entry.
  • No compatibility shim: the repo is the only consumer.

Test plan

  • uv run pytest -m "not live" (1181 passed)
  • uv run ruff check . and ruff format --check .
  • uv run python vera.py generate --help and python -c "import generate"
  • git grep generate_conversations finds only the CHANGELOG entry and uv.lock

🤖 Generated with Claude Code

docs/architecture.md already named generate/ as the permanent home for
the generation package; moving generate.py into legacy/ removed the
collision with a root module. Update imports, patch targets, docs, and
the vera.py thin-entry-point assertion accordingly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@luca-belli
luca-belli requested a review from a team as a code owner October 8, 2026 19:39

@jgieringer jgieringer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@luca-belli
luca-belli merged commit 6b8ebe4 into main Oct 8, 2026
3 checks passed
@luca-belli
luca-belli deleted the refactor/rename-generate-package branch October 8, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants