Repository navigation
feat: add vera pool, moving pooling into score/pool.py - #255
Merged
Merged
Conversation
luca-belli
marked this pull request as draft
October 9, 2026 19:11
luca-belli
commented
Oct 13, 2026
luca-belli
force-pushed
the
feat/vera-pool
branch
from
October 13, 2026 15:56
cc1c732 to
0e8876f
Compare
This was referenced Oct 13, 2026
luca-belli
marked this pull request as ready for review
October 13, 2026 17:40
Pure move, so history follows the file. The recommended shell pipeline now runs it as a module, like legacy.run_pipeline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
score.run_pooling holds the logic from the pool script, unchanged except that no personas file skips the risk breakdown, as in vera score. The legacy script becomes a thin wrapper over it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
luca-belli
force-pushed
the
feat/vera-pool
branch
from
October 13, 2026 20:10
0e8876f to
006f0b8
Compare
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
vera pool, the first step of the roadmap's Scoring split phase.vera judge --help, aJudgingConfigerror, the docs, andvera pipeline's output already pointed users to this command.Stacked on #251. Both PRs touch
legacy/run_recommended_vera_pipeline.sh. GitHub retargets this PR tomainonce #251 merges.vera pool(vera_cli/pool.py):--evaluations <a> <b> ...(2 or morej_*folders or theirresults.csv),-o(defaultoutput/),--personas,--skip-risk-analysis,--config,--print. The config section ispooling(newPoolingConfiginutils/config_schema.py). Built likevera score.scripts/pool_vera_scores.pytoscore/pool.py(from score import run_pooling). The only intended behavior change is that no personas file skips the risk breakdown, as invera score, instead of defaulting todata/SI/personas.tsv. Output layout and folder naming are unchanged until the Traceability phase.legacy/pool_vera_scores.py(python -m legacy.pool_vera_scores). Its flags, SI default, and--extract-from-logare unchanged. The recommended shell pipeline calls it as a module.docs/cli.md(newvera poolsection, removed from "Not built yet"),docs/scoring.md,docs/legacy-scripts.md,vera_cli/README.md,AGENTS.md,docs/roadmap.md,docs/ARCHITECTURE-SPINE.md(open question resolved), CHANGELOG.Not in this PR: making
vera pipelineend with the pooled score. That reverses a rule onmain(test_pipeline_runs_three_stages_and_never_pools) and gets its own PR.Behavior unchanged
I compared every moved function's parsed code with the original script. All helpers, naming, merging, and scoring code are identical. The only differences are the rename (
pool_evaluation_directories→ keyword-onlyrun_pooling), imports moved to module level, and the personas default described above.Test plan
uv run pytest -m "not live"(1211 passed, 30 new)tests/unit/test_vera_pool.py: CLI and config handling,--printround trip, outputs, personas and skip-risk behaviortests/unit/score/test_pool.py: naming and input helpers (previously untested)tests/integration/test_pool_parity.py: legacy script vsvera poolgive the sameresults.csv,scores.json,scores_by_risk.json;--extract-from-logstill worksruff check,ruff format --check,pyright generate score utils vera_cli vera.py(0 errors)bash -n legacy/run_recommended_vera_pipeline.sh🤖 Generated with Claude Code