Skip to content

fix ci flow and stop of nipapd - #1465

Merged
garberg merged 4 commits into
SpriteLink:masterfrom
axians:ci-docker-upstream-only
Oct 12, 2026
Merged

garberg merged 4 commits into
SpriteLink:masterfrom
axians:ci-docker-upstream-only

Conversation

@SoundGoof

Copy link
Copy Markdown
Contributor

Update CI actions and fix issues encountered when building, installing and testing NIPAP packages.

  • Update checkout and Docker actions to their latest major versions, and update Hadolint.
  • Generate embedded SQL before building the backend and include the schema 7→8 migration.
  • Add missing Debian dependencies and propagate package build failures.
  • Fix daemon shutdown and process matching, set PID file permissions to 0644, and wait for shutdown before restarting.
  • Install a systemd stop override for the SysV service.
  • Limit the Hadolint exception to the existing public guest credentials.
  • restrict docker push to only run on spritlink org

The compatibility chmod in the init script and the systemd stop override can be removed in a follow-up once the daemon fixes are merged and verified in the packages used by CI.

Comment thread nipap/nipap/nipapd.py Outdated
except IOError:
logger.error('NIPAPd already running (pid: ' + lf.read().strip() + ')')
sys.exit(1)
# Daemonization resets the umask; allow PID reads but only owner writes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

@garberg
garberg merged commit 8685bdd into SpriteLink:master Oct 12, 2026
6 checks passed
@garberg

garberg commented Oct 12, 2026

Copy link
Copy Markdown
Member

Thx for contributing! :)

@SoundGoof
SoundGoof deleted the ci-docker-upstream-only branch October 23, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants