Remove Postgres backups#18
Open
nmaludy wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Closes #7 |
blag
suggested changes
Sep 25, 2020
blag
left a comment
blag
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good, but we still presumably have a substantial install base with versions of StackStorm installed that still support Mistral. If this PR is merged as-is, and those users install the new version of this pack, their PostgreSQL database will suddenly not get backed up.
Let's add a stackstorm_version key to the pack.yaml file to keep users of older versions of StackStorm using previous versions of this pack. See the Bitbucket pack for an example.
Contributor
|
@nmaludy I think it would be useful to:
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
As part of the mistral deprecation / removal this removes the Postgres backups from this pack as they are no longer needed