feat: add searchByMemo, validateSplitTotal/normalizeSplits, and has/purgeExpired to cache (Closes #614, #609, #606) - #628
Open
waterWang wants to merge 1 commit into
Conversation
…urgeExpired to cache - Stellar-split#614: searchByMemo invoices by memo content substring (case-insensitive by default) - Stellar-split#609: validateSplitTotal with bigint precision + normalizeSplits with remainder distribution - Stellar-split#606: has() and purgeExpired() methods on SimpleCache All 26 tests pass across 3 new/updated test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements three independent features:
#614 — Add searchByMemo to search.ts
searchByMemo(invoices, query, opts?)performs substring search on invoice memo fieldsopts.caseSensitiveoverride#609 — Add validateSplitTotal and normalizeSplits to splitRatioValidator
validateSplitTotal(splits, totalBasisPoints?)validates bigint splits sum to exact total (default 10000n)StellarSplitErrorwith codeINVALID_RECIPIENTon mismatchnormalizeSplits(amounts, total)distributes rounding remainder to the last element#606 — Add has() and purgeExpired() to SimpleCache
has(key)checks existence and TTL expirypurgeExpired()removes all expired entries in one sweep, returns count removedTests
All 26 tests pass.