feat: add investment share percentage calculator and tests - #240
Open
probablyABug wants to merge 1 commit into
Open
feat: add investment share percentage calculator and tests#240probablyABug wants to merge 1 commit into
probablyABug wants to merge 1 commit into
Conversation
|
@probablyABug Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #204
Adds unit test coverage for the investment share percentage calculator, verifying that percentage calculations use integer arithmetic and always produce a total of exactly 100%. The tests cover equal and unequal investment splits, single-investor cases, and correct allocation of rounding remainders to the largest investor.
Type of Change
Checklist
feat:,fix:,chore:, etc.) — enforced by CI.env, or credentials committed (seeCONTRIBUTING.md)Testing
Added unit tests for the investment share percentage calculator covering equal splits, unequal splits, single-investor calculations, and rounding remainder allocation.
How to Test
Test Coverage
Screenshots (if applicable)
Not applicable — this PR adds backend unit test coverage only.
Additional Notes
The tests specifically guard against floating-point rounding drift in investment share calculations. They also verify that any percentage remainder is assigned consistently to the investor with the largest commitment.
For Reviewers