Remove four Config settings nothing reads - #165
Merged
Conversation
playerSaveFile, statsSaveFile and timeServiceSaveFile were made obsolete by the multi-slot save layout (SaveFileManager composes paths from the selected slot instead); initialEnergy was never wired up since player.py deliberately sources starting energy from the housing ladder. All four looked like live configuration but silently did nothing if edited. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric:
Summary: dead-code removal, all applicable items pass, CI green. Ready to merge. drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config.playerSaveFile,statsSaveFile, andtimeServiceSaveFile— the multi-slot save layout resolves paths throughSaveFileManager.get_save_path()instead, so these three have been dead since Multiple save files #51; a grep confirms every remaining match outsideconfig.py/the test was a localasvariable infishE.py, neverself.config.*.Config.initialEnergy—player.pyalready documents that starting energy deliberately comes from the housing ladder, not a configured value, so the attribute had no reader. Updated that comment since it referenced the now-removed attribute by name.tests/config/test_config.py(they were pinning dead values) and dropped the now-unusedosimport.Test plan
python3 -m compileall -q srcSDL_VIDEODRIVER=dummy SDL_AUDIODRIVER=dummy python3 -m pytest— 729 passedgrep -rn '\.playerSaveFile\|\.statsSaveFile\|\.timeServiceSaveFile\|\.initialEnergy' --include='*.py' .— no remaining references anywhereCloses #147
drafted by Claude on behalf of Daniel Stephenson