Skip to content

Improve process error handling#532

Merged
rob93c merged 3 commits into
mainfrom
improve-process-error-handling
Jul 21, 2026
Merged

Improve process error handling#532
rob93c merged 3 commits into
mainfrom
improve-process-error-handling

Conversation

@rob93c

@rob93c rob93c commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Reduced ffprobe output noise during media information extraction.
    • Improved command execution by capturing standard output and error separately.
    • Timeout and failure warnings now include collected error details to help diagnose media processing issues.

@rob93c rob93c self-assigned this Jul 21, 2026
@rob93c rob93c added enhancement New feature or request logs This marks changes revolving around logs labels Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ed7cff21-1ef8-423f-a2cd-d31e21926b6b

📥 Commits

Reviewing files that changed from the base of the PR and between e5e1b33 and 949722d.

📒 Files selected for processing (1)
  • src/main/java/com/github/stickerifier/stickerify/process/ProcessHelper.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/com/github/stickerifier/stickerify/process/ProcessHelper.java

📝 Walkthrough

Walkthrough

Changes

Process execution now captures standard output separately from standard error and logs captured errors for timeouts and non-zero exits. Media metadata extraction invokes ffprobe with error-level logging.

Media process output handling

Layer / File(s) Summary
Separate process output streams
src/main/java/com/github/stickerifier/stickerify/process/ProcessHelper.java
executeCommand reads standard output and standard error independently using virtual threads, joins both readers, updates timeout and exit handling, and documents standard-output returns.
Use ffprobe error logging
src/main/java/com/github/stickerifier/stickerify/media/MediaHelper.java
retrieveMultimediaInfo changes the ffprobe verbosity option from -v quiet to -v error.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: improving process command error handling and timeout logging.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7b756258-675d-4043-9f24-71a5a1a3e658

📥 Commits

Reviewing files that changed from the base of the PR and between e72b51f and e5e1b33.

📒 Files selected for processing (2)
  • src/main/java/com/github/stickerifier/stickerify/media/MediaHelper.java
  • src/main/java/com/github/stickerifier/stickerify/process/ProcessHelper.java

Comment thread src/main/java/com/github/stickerifier/stickerify/process/ProcessHelper.java Outdated
@rob93c
rob93c marked this pull request as ready for review July 21, 2026 09:47
@rob93c
rob93c requested a review from MartelliEnrico July 21, 2026 09:48
@rob93c

rob93c commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@MartelliEnrico MartelliEnrico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rob93c
rob93c merged commit a99d96d into main Jul 21, 2026
8 checks passed
@rob93c
rob93c deleted the improve-process-error-handling branch July 21, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request logs This marks changes revolving around logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants