Repository navigation
Cache Slack images in /tmp instead of ~/.cache - #2
Merged
Merged
Conversation
Stale paths self-heal: the fetch is keyed on cache-miss, so if the OS prunes a /tmp file, a later read just re-downloads it. No need for a durable dir or a retention policy. Override still honored via SLACK_IMAGE_CACHE_DIR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the image cache dir from
~/.cache/golem-slack-imagesto/tmp/golem-slack-images.Rationale: the download is keyed on cache-miss (
if not path.exists(): download), so if macOS prunes an old/tmpfile, a later read simply re-pulls it — stale paths self-heal. That removes the only reason we were using a durable dir, and avoids unbounded growth without needing a retention policy.SLACK_IMAGE_CACHE_DIRoverride still honored.Tested: annotation now emits
path=/tmp/golem-slack-images/…, image downloads and reads back as a valid PNG.