Remove the passive Slack listener; outbound only - #6
Merged
Merged
Conversation
The listener spawned a full `claude -p` for every unowned message in a watched channel. That is expensive, answers people who were not talking to us, and is superseded by QM, which handles inbound Slack with per-person scopes and its own turn detection. Removed: Socket Mode connection, leader election and its lock file, the JSONL event bus, the event-bus tailer, cold replies, and channel notifications -- along with the claude/channel capability, since nothing pushes any more. SLACK_APP_TOKEN is no longer read at all. Kept: every outbound tool (reply, read_history, get_thread, fetch_file, add_reaction, remove_reaction, list_channels, debug) and per-conversation thread tracking. 1234 -> 887 lines. Verified against the venv actually in use (mcp 1.28.1): module imports, all eight tools present, no listener symbols, and auth_test still succeeds as @golem. Note: a fresh resolve picks mcp 2.0.0, where the lowlevel Server API has no list_tools and the module fails to import. That pre-dates this branch -- pristine main fails identically -- but pyproject's `mcp>=1.26.0` should probably be capped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Golem no longer needs to listen — QM handles inbound Slack, with per-person scopes and its own turn detection. The listener here spawned a full
claude -pfor every unowned message in a watched channel, which was expensive and answered people who weren't talking to us.Removed
Socket Mode connection, leader election + lock file, the JSONL event bus and its tailer, cold replies, channel notifications, and the
claude/channelcapability.SLACK_APP_TOKENis no longer read.Kept
All eight outbound tools —
reply,read_history,get_thread,fetch_file,add_reaction,remove_reaction,list_channels,debug— plus per-conversation thread tracking. 1234 → 887 lines.Verified
Against the venv actually in use (mcp 1.28.1), not a fresh resolve: module imports cleanly, all eight tools present, no listener symbols remain,
auth_teststill succeeds as@golem.Unrelated issue worth flagging
A fresh dependency resolve picks mcp 2.0.0, where the lowlevel
Serverhas nolist_toolsand the module fails to import outright. This pre-dates the branch — pristinemainfails identically — butmcp>=1.26.0in pyproject probably wants an upper bound.