Cap mcp below 2.0 - #7
Merged
Merged
Conversation
mcp 2.x moved the lowlevel Server API -- there is no .list_tools -- so a fresh resolve produces an install where the module fails to import outright: AttributeError: 'Server' object has no attribute 'list_tools' Existing environments were pinned by their lockfile and unaffected, which is why this went unnoticed; it only bites on a clean install. Found while giving the plugin a standalone venv so it no longer has to be installed via golem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh dependency resolve picks mcp 2.0.0, where the lowlevel
ServerAPI moved and has no.list_tools. The module then fails to import outright:Existing environments were pinned by their lockfiles and unaffected — which is why nobody hit it. It only bites on a clean install, which is exactly what happens when the plugin is installed standalone rather than through golem.
Verified: with the cap, a fresh venv resolves mcp 1.29.0, imports cleanly, and exposes all 8 tools.