Pass experimental_capabilities to get_capabilities - #8
Merged
Merged
Conversation
mcp 1.29 made experimental_capabilities a required argument of Server.get_capabilities(). The call site only passed notification_options, so every server start raised TypeError inside the stdio task group — and because it happens after import, at connection time rather than load time, the failure looked like the MCP server was simply dead rather than erroring. Existing venvs resolved to an older mcp and were unaffected; a fresh install (the standalone venv) picks up 1.29 and hits it immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcp 1.29 made
experimental_capabilitiesa required positional argument ofServer.get_capabilities(). We only passednotification_options, so the server raisedTypeErrorinside the stdio task group on every start.Because that happens at connection time rather than import time, the symptom is "the MCP server is failing completely" rather than a clear import error.
Existing venvs pinned an older mcp and were shielded; the fresh standalone venv resolves 1.29 and hits it immediately.
Verified after the fix:
initializereturns cleanly andtools/listenumerates all 8 tools.