Repository navigation
perf(streaming): overlap 720p frame packing with scanout - #366
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 74.44% 74.49% +0.05%
==========================================
Files 72 72
Lines 8224 8237 +13
Branches 3517 3532 +15
==========================================
+ Hits 6122 6136 +14
+ Misses 1102 1101 -1
Partials 1000 1000
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
At 720p60, waiting for a reusable YUY2 buffer before packing the next frame can cause the presenter to miss a refresh. An optional third buffer lets the client pack the next frame and compose the overlay while the previous submission waits for vertical blank. The presenter still waits for that latch before submitting to the same NV2A overlay bank.
The spare uses up to 1.76 MiB of contiguous memory and is available in 720p output mode. If its allocation fails, the presenter uses two buffers.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
Ran the same six streaming modes against
22f9024and the proposed change using fixed H.264 clips replayed by a local Sunshine host. Each result covers about 10 seconds after warmup in xemu with Vulkan, 64 MiB of guest memory, and GPU presentation enabled.At 720p60, client drops fell from 143 to 17. A repeat in reverse order improved from 49.6 to 57.1 FPS. Mean client presentation preparation and submission time was 15.02 to 14.85 ms in the first comparison and 13.01 to 12.67 ms in the repeat. Physical Xbox throughput and end-to-end latency still need validation.
cmake --build cmake-build-release --parallel 8built the Xbox release ISO.ctest --test-dir cmake-build-release --output-on-failurepassed all 504 native tests. New tests cover packing before the prior latch, buffer rotation, spare allocation failure, and recovering software output after a scanout timeout.cmake --build cmake-build-release --target docspassed the strict API documentation build.uv run --locked lb-update-clang-formatandgit diff --checkpassed.Type of Change
Checklist
AI Usage
See our AI usage policy.