Repository navigation
Make MelodyMath installable and document the Google Play path - #1000
Merged
Merged
Conversation
…y path. Link the manifest, Apple touch icon, and theme color from every entry page, register the service worker at the site-root scope, and keep the offline cache versioned so one missing file cannot block installation. Add Bubblewrap config and release steps without keys or a store listing. Co-authored-by: Aviran Swissa <swissa.aviran@s.afeka.ac.il>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Keep master's precache list and move the offline cache to v102, one past master's v101, because the shell still installs with addAll while the rest of the list is best-effort. Maskable icons, manifest links, and the Play path docs stay. Co-authored-by: Aviran Swissa <swissa.aviran@s.afeka.ac.il>
CodeQL js/incomplete-sanitization flagged prefix.replace(/[.]/g, '\\.') because a backslash in the path was left unescaped before the string was compiled as a regular expression. Read the href from the link tag instead. Run installSharedChrome against a document double so the new meta tags and the service-worker scope are executed and counted by patch coverage. Co-authored-by: Aviran Swissa <swissa.aviran@s.afeka.ac.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The manifest, service worker, and icons were already in the repo, and
src/lib/core.jsadded the manifest link only after JavaScript ran. The HTML itself did not link the manifest, and iOS never received the Apple web-app tags, so the live site was not a proper installable app.This links the manifest, Apple touch icon, theme color, and iOS standalone tags from every entry page, and registers the service worker with the site-root scope. On GitHub Pages that scope is
/MelodyMath/. Hebrewlang="he"anddir="rtl"are unchanged, and no visible copy or colors of the pages were edited. The offline cache is nowmelodymath-offline-v53: the shell installs even if one later file 404s, and a navigation that cannot reach the network falls back to the cached page, thenindex.html. Cached files still refresh in the background so a fix shows up on the next visit without mixing a new page with an old script.The GitHub release
v1.0.0-androidis not a Play build.MelodyMath.apk(uploaded 2026-10-12) is a debug-signed Kotlin WebView shell (com.swissystem.melodymath, Android Gradle Plugin 8.5.2) that loadsfile:///android_asset/www/index.html. It is not Capacitor and not a Trusted Web Activity. The bundled site matches commit27f66919302fb81cee74168a45df8feec3356bff(service workermelodymath-offline-v15), not currentmaster. The Android project was never committed, and Play will not accept the Android debug certificate.docs/android-release.mdandandroid/twa-manifest.jsonare the Bubblewrap path (CLI 1.27.0,targetSdkVersion 36). No keystore, Play account, or listing is included..well-known/assetlinks.json.exampleis only a template: Play reads asset links fromhttps://swissystem7.github.io/.well-known/assetlinks.json, which is the user site repo, not this project.Installability
Lighthouse 12.8.2 no longer has a PWA category (asking for it returns an empty report). The check below is Chrome's own installability API, which is what that category used to report.
Against a local server of this branch:
http://127.0.0.1:8090/MelodyMath/index.html(the GitHub Pages path shape):Page.getInstallabilityErrorsis empty. The manifest parses with no errors. The service worker scope ishttp://127.0.0.1:8090/MelodyMath/, the script is.../MelodyMath/sw.js, stateactivated, and it controls the page.http://127.0.0.1:8080/index.html) is clean, with scope/.lang=he,dir=rtl).npm test: 2107 tests, 2089 passed, 0 failed.Owner steps still required
Full commands are in
docs/android-release.md.android/runnpx @bubblewrap/cli@1.27.0 update --skipVersionUpgradeandbuild. Uploadapp-release-bundle.aab. Package idcom.swissystem.melodymathis permanent. FirstappVersionCodeis 1.https://swissystem7.github.io/.well-known/assetlinks.jsonin the reposwissystem7/swissystem7.github.io. With Play App Signing, that fingerprint is the app signing certificate from Play Console, not only the upload key. The maskable icon URL must be live on Pages beforebubblewrap updatefetches it.https://swissystem7.github.io/MelodyMath/privacy.html. Data safety should match that page.node tools/pr-size.jsreports 548 lines, over the auto-merger's 400-line ceiling. This PR is not for auto-merge.Open PRs that also touch
sw.js,index.html, or the manifest: #954, #953, #952.