Skip to content

fix: unify on פַּעֲמָה / פְּעָמוֹת, and match אי־זוגי - #1106

Merged
Swissystem7 merged 2 commits into
masterfrom
cursor/paama-hebrew-bf38
Nov 17, 2026
Merged

Swissystem7 merged 2 commits into
masterfrom
cursor/paama-hebrew-bf38

Conversation

@Swissystem7

Copy link
Copy Markdown
Owner

Why

Issue #1096, owner's decision: one Hebrew term, the Academy's music word פַּעֲמָה / פְּעָמוֹת, everywhere in the bank, the UI, the tests and the regexes. "פעימה" is the pulse used in physics and sport. The bank was mixing the two (and an unvocalized פעמה).

The replacement is spelling only. Item ids are grade-skill-index in the bank array, and nothing was inserted, deleted or reordered, so ids stay put. Bells (פעמון) and "פעמיים" were not touched.

Regexes that looked for the old stem (פעימ) could not see the vocalized word, because the vowel marks sit between the letters. Those checks now strip the marks and look for פעמ.

Also from #1085: dataWorlds compared the parity answer with !==, so אי-זוגי and אי־זוגי did not match and an odd item would not sound. The comparison now folds hyphen and maqaf. The revealed answer keeps the spelling the item itself uses. isCorrect already treated them as the same typed answer.

Size

About 1,900 changed lines, almost all one-word substitutions across 113 files. It is over the 400-line auto-merge ceiling. Splitting it would leave the bank on one spelling and a regex on the other, so this stays one change.

Tests

test/paamaSpelling.test.js walks src and test and fails if the old spellings remain, and it checks that a maqaf answer and an ASCII-hyphen answer both plan the same odd sum.

Refs #1096, #1085. Do not merge from this branch.

Open in Web Open in Cursor 

The bank, the lessons and the tests mixed פעמה with פעימה, which is
the pulse of physics rather than the musical beat. Both spellings are
now the vocalized Academy form, including the regexes that match
prompts. Item ids and order are unchanged.

An odd/even answer written with a maqaf (אי־זוגי) now matches the
same word written with an ASCII hyphen, so the sound plan is not
dropped on the hyphen.

Co-authored-by: Aviran Swissa <swissa.aviran@s.afeka.ac.il>
@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.56710% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/DataBeats.js 87.50% 1 Missing ⚠️
src/lib/core.js 0.00% 1 Missing ⚠️
src/lib/exercises/interactiveExplorers.js 85.71% 1 Missing ⚠️
src/lib/exercises/variety.js 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Keep the count-up stand marker and difference prompts from master,
and name those beats with the Academy spelling פַּעֲמָה. The phone-speaker
check uses that same spelling so the 4/4 phrase still plans.

Co-authored-by: Aviran Swissa <swissa.aviran@s.afeka.ac.il>
@Swissystem7
Swissystem7 merged commit 915dab3 into master Nov 17, 2026
5 checks passed
@Swissystem7
Swissystem7 deleted the cursor/paama-hebrew-bf38 branch November 17, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants