Skip to content

Add an opt-in Biome style check - #214

Merged
Swissystem7 merged 1 commit into
masterfrom
cursor/add-biome-check-9bf2
Nov 17, 2026
Merged

Swissystem7 merged 1 commit into
masterfrom
cursor/add-biome-check-9bf2

Conversation

@Swissystem7

Copy link
Copy Markdown
Owner

Summary

Adds Biome 2.6.7 as a local, opt-in check, following the same setup as DoMeAfavor. CI workflows are unchanged.

  • biome.json uses schema 2.6.7. VCS is git with useIgnoreFile. files.ignoreUnknown is true and only **/*.js is included. The formatter uses spaces, indent 2, line width 120, single quotes, semicolons always, and no trailing commas (the style the existing JS already uses). Assist is off.
  • package.json pins @biomejs/biome at 2.6.7 and adds check:style (biome check). The test script is unchanged. This repo has no package-lock.json, so none was added.
  • README mentions npm run check:style in one Hebrew line and notes that the check does not run in CI.

Formatter override

These existing files are not already formatted, so the formatter is disabled for them. npx @biomejs/biome@2.6.7 check does not rewrite them. New JS files are formatted.

  • attic/proof-big5.js
  • attic/proof-body.js
  • attic/proof-composite.js
  • attic/proof-demo.js
  • attic/proof-identity.js
  • attic/proof-match.js
  • attic/proof-offball.js
  • attic/proof-tournament.js
  • attic/proof-xt.js
  • basketball.js
  • demo.js
  • test/basketball.test.js
  • test/byod.test.js
  • test/csv-export-with-provenance.test.js
  • test/data.test.js
  • test/demo.test.js
  • test/filter-by-position.test.js
  • test/lessonFirstStructure.test.js
  • test/links.test.js
  • test/pages.test.js
  • test/position-ut-audit.test.js
  • test/pr-size.test.js
  • test/trap.test.js
  • tools/make-basketball-example.js
  • tools/pr-size.js
  • trap.js

Already formatted, so left under the formatter:

  • test/dom-ids.test.js
  • test/meta.test.js
  • test/panim.test.js
  • test/selected-fallback.test.js

Rules downgraded to warn

Noisy legacy rules from the recommended preset, same set called out for this repo:

  • correctness.noInnerDeclarations (no current hits)
  • suspicious.noRedeclare (no current hits)
  • suspicious.noAssignInExpressions (hits in the current tree)
  • suspicious.useIterableCallbackReturn (hits in the current tree)

No other rule was downgraded.

Lint fix

One recommended-preset error remained: rankOf in basketball.js took a parameter named valueOf, which shadows the restricted global. Renamed to readValue. Call sites pass a function as the second argument, so behavior is unchanged.

Checks

  • npx @biomejs/biome@2.6.7 check exits 0 (371 warnings, 228 infos, 0 errors).
  • npm run check:style exits 0.
  • npm test — 185 tests, 0 failures.
Open in Web Open in Cursor 

Pin Biome 2.6.7 for a local check:style script. Leave unformatted legacy JS alone via a formatter override, and rename the valueOf parameter that shadowed a restricted global.

Co-authored-by: Aviran Swissa <swissa.aviran@s.afeka.ac.il>
@Swissystem7
Swissystem7 merged commit 42a09aa into master Nov 17, 2026
4 checks passed
@Swissystem7
Swissystem7 deleted the cursor/add-biome-check-9bf2 branch November 17, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants