Skip to content

Add an opt-in Biome 2.6.7 style check - #215

Merged
Swissystem7 merged 1 commit into
masterfrom
cursor/add-biome-check-c436
Nov 17, 2026
Merged

Swissystem7 merged 1 commit into
masterfrom
cursor/add-biome-check-c436

Conversation

@Swissystem7

Copy link
Copy Markdown
Owner

Adds Biome 2.6.7 as a local, opt-in style check, following the same setup as Swissystem7/DoMeAfavor. CI is unchanged: nothing under .github/ was edited, and npm test is still node --test.

npm run check:style runs biome check. Quote style is single quotes with semicolons always and no trailing commas, which is what the existing JavaScript mostly uses.

Checks

  • npx @biomejs/biome@2.6.7 check exits 0 (0 errors; 173 warnings and 150 infos, all on legacy code).
  • npm test — 497 pass, 0 fail.

Formatter override

The formatter is disabled for the 87 existing JS files that are not already formatted, so the check passes on the current tree without rewriting them. New files, and the 20 JS files that already match the formatter, stay formatted.

Already formatted (formatter left on):

  • test/404-ui.test.js
  • test/control-custom-panel.test.js
  • test/control-darkness.test.js
  • test/control-panel-guard.test.js
  • test/control-protections.test.js
  • test/feedback.test.js
  • test/firmware-build.test.js
  • test/hil.test.js
  • test/power-draw-defaults.test.js
  • test/power-peak-phase.test.js
  • test/power-sleep.test.js
  • test/protocol-strict-panel.test.js
  • test/readme-api.test.js
  • test/safety.test.js
  • test/set-panel-retarget.test.js
  • test/smoke-390.test.js
  • test/target-quantised.test.js
  • test/timing-summary.test.js
  • test/torque-max-mass.test.js
  • test/torque-verdict-bands.test.js

Formatter disabled:

  • config/contact.js
  • scripts/lib/pr-split.js
  • scripts/pr-size.js
  • scripts/smoke.js
  • scripts/sync-control-params.js
  • src/lib/alts.js
  • src/lib/bom.js
  • src/lib/case.js
  • src/lib/contact.js
  • src/lib/control-params.js
  • src/lib/control.js
  • src/lib/feedback.js
  • src/lib/fsm-table.js
  • src/lib/fsm.js
  • src/lib/gantt-chart.js
  • src/lib/hil.js
  • src/lib/optics.js
  • src/lib/power.js
  • src/lib/protocol.js
  • src/lib/safety.js
  • src/lib/sentryLoader.js
  • src/lib/timing.js
  • src/lib/torque.js
  • src/lib/userValidation.js
  • test/alts-search.test.js
  • test/alts-ui.test.js
  • test/alts.test.js
  • test/bh1750-begin-addr.test.js
  • test/bom.test.js
  • test/case-ui.test.js
  • test/case.test.js
  • test/contact.test.js
  • test/control-params.test.js
  • test/control.test.js
  • test/dashboard-target-step.test.js
  • test/dashboard-ui.test.js
  • test/deadband-target.test.js
  • test/emergency-stop.test.js
  • test/firmware-min-types.test.js
  • test/firmware-mirror.test.js
  • test/fsm-angle-error.test.js
  • test/fsm-events-ui.test.js
  • test/fsm-matrix.test.js
  • test/fsm-stop.test.js
  • test/fsm-ui.test.js
  • test/fsm.test.js
  • test/gantt-chart.test.js
  • test/geometry-facing.test.js
  • test/geometry-ui.test.js
  • test/hil-example-1.test.js
  • test/hil-hazard-ui.test.js
  • test/hil-ui.test.js
  • test/lab-stop.test.js
  • test/lab-target-mirror.test.js
  • test/lab-ui.test.js
  • test/landing-ui.test.js
  • test/lroundf-float32.test.js
  • test/optics-params.test.js
  • test/optics-unknown.test.js
  • test/optics.test.js
  • test/pages.test.js
  • test/power-best-pack.test.js
  • test/power-day-24h.test.js
  • test/power-presets-interactions.test.js
  • test/power-presets-ui.test.js
  • test/power-ui.test.js
  • test/power.test.js
  • test/pr-split.test.js
  • test/protocol-demo-target.test.js
  • test/protocol-method-matrix.test.js
  • test/protocol-methods-ui.test.js
  • test/protocol-ui.test.js
  • test/protocol.test.js
  • test/runtime-loop-presets.test.js
  • test/runtime-presets.test.js
  • test/sentryCodecov.test.js
  • test/spec-bom-filter.test.js
  • test/spec-presets.test.js
  • test/spec-safety-ui.test.js
  • test/spec-torque-ui.test.js
  • test/status-lux-null.test.js
  • test/testing-doc.test.js
  • test/timing.test.js
  • test/torque-tilt-domain.test.js
  • test/torque.test.js
  • test/userValidation.test.js
  • tools/codecov.js

Rules downgraded to warn

Set to warn up front, same noisy legacy rules as DoMeAfavor. No further rules were downgraded: after the formatter override, Biome reported no lint errors, so no source files were changed to fix bugs.

  • correctness.noInnerDeclarations
  • suspicious.noRedeclare
  • suspicious.noAssignInExpressions
  • suspicious.useIterableCallbackReturn

Other

test/pages.test.js asserted that package.json had no devDependencies. It now allows exactly @biomejs/biome at 2.6.7 and still requires test to stay node --test.

Open in Web Open in Cursor 

Pin @biomejs/biome and expose it as npm run check:style. Legacy JS
that is not already formatted keeps the formatter off, so the check
passes on the current tree without a reformat. CI is unchanged.

Co-authored-by: Aviran Swissa <swissa.aviran@s.afeka.ac.il>
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Swissystem7
Swissystem7 merged commit f67cb58 into master Nov 17, 2026
5 checks passed
@Swissystem7
Swissystem7 deleted the cursor/add-biome-check-c436 branch November 17, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants