Default deltaGCSV missingValue to the yeast-GEM sentinel for parity - #705
Merged
Conversation
deltaGCSV gained an optional missingValue argument in #702, but defaulted it to [] (disabled), while raven-toolbox's load_delta_g_csv defaults missing_value to DELTA_G_MISSING (1e7). The two implementations therefore disagreed on default behaviour: loading yeast-GEM's own deltaG CSVs, RAVEN stamped the 777 sentinel rows as literal 1e7 measurements while raven-toolbox left them unset. That is the exact discrepancy the parity issue tracks. Default missingValue to 1e7 so both sides drop the sentinel out of the box. No real deltaG in kJ/mol takes this value, so the default is safe; passing [] disables it and stores every value literally, mirroring missing_value=None. The comparison tolerance already matched (math.isclose rel_tol=1e-9). Resolves the default half of SysBioChalmers/raven-gecko-parity#16.
Function test results302 tests 276 ✅ 1m 7s ⏱️ Results for commit 04739b0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #702, resolving the remaining half of SysBioChalmers/raven-gecko-parity#16.
#702 added an optional
missingValueargument todeltaGCSVbut defaulted it to[](disabled), while raven-toolbox'sload_delta_g_csvdefaultsmissing_valuetoDELTA_G_MISSING(1e7). So with defaults, the two disagreed: loading yeast-GEM's own ΔG CSVs, RAVEN stamped the 777 sentinel rows as literal 1e7 measurements while raven-toolbox left them unset.This defaults
missingValueto1e7, so both implementations drop the sentinel out of the box. No real ΔG (in kJ/mol) takes this value, so the default is safe. Passing[]disables it and stores every value literally, mirroringmissing_value=None. The comparison tolerance already matched (math.iscloserel_tol=1e-9).Tests: adds
deltaGCsvDropsSentinelByDefaultanddeltaGCsvKeepsSentinelWhenDisabledto tAnnotation.