Revert "YAML I/O: quote with double quotes, matching Prettier's default" - #713
Merged
Conversation
Reverts the quote-character choice from #710 back to single quotes. writeYAMLmodel emits single quotes when a scalar needs quoting again, exactly as before #710 (verified: byte-identical output to the pre-#710 writer on tutorial/smallYeast.yml, same SHA256). readYAMLmodel's unescaping keeps handling both quote styles (it already did, to read files written either way) and #712's list-item quote-marker-stripping fix is untouched --- that bug affected quoted list items under either quote convention and isn't specific to which character is used, so there's no reason to revert it.
Function test results303 tests 276 ✅ 1m 7s ⏱️ Results for commit 2eed9e5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the quote-character choice from #710 back to single quotes, per request.
writeYAMLmodelemits single quotes when a scalar needs quoting again, exactly as before #710.readYAMLmodel's unescaping keeps handling both quote styles (it already did, to read files written either way — a reader should be liberal in what it accepts even if the writer only emits one). #712's list-item quote-marker-stripping fix is untouched: that bug affected a quoted list item under either quote convention and isn't specific to which character is used, so there's no reason to revert it.Test plan
tSyntax,tIO— 15 passed, 0 failed, 1 filtered (unrelated missing dependency)write_yaml_model(paired PR) for the same model: identical SHA256, and identical to the pre-YAML I/O: quote with double quotes, matching Prettier's default #710 writer's own output (same hash as the original byte-identity verification)