Skip to content

perf: only write unsaved studio projects on disconnect and shutdown - #30

Merged
Nowkoo merged 1 commit into
fix/multitrack-recording-bugsfrom
perf/studio-dirty-saves
Oct 11, 2026
Merged

Nowkoo merged 1 commit into
fix/multitrack-recording-bugsfrom
perf/studio-dirty-saves

Conversation

@Nowkoo

@Nowkoo Nowkoo commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Stacked on the note-memory PR.

Cached projects already match their files, except a final take that is still saving or whose write failed. Disconnects and shutdown now retry only those.

  • Before, every disconnect rewrote the player's project, and shutdown rewrote every cached project on the single writer thread. With many players that could reach the 5-second shutdown timeout, with a genuinely unsaved take queued behind redundant writes.
  • A disconnect now evicts a current project from memory; the next visit reloads it.
  • "Take saved" is announced only for finished takes. It is no longer sent to everyone online at shutdown.

Validation: Java 21 mvn clean verify, 289 tests, 100% instruction and branch coverage.

🤖 Generated with Claude Code

Cached projects already match their files except for a final take that
is still saving or whose write failed. Disconnects and shutdown now
retry only those, instead of rewriting every cached project and risking
the shutdown timeout. A disconnect evicts a current project from memory.
"Take saved" is announced only for finished takes, not for these saves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 11, 2026
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eb82a3f7-eb9c-4b7f-9683-6038737cc5ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Base automatically changed from perf/studio-note-memory to fix/multitrack-recording-bugs October 11, 2026 19:37
@Nowkoo
Nowkoo merged commit e00d8b4 into fix/multitrack-recording-bugs Oct 11, 2026
2 checks passed
@Nowkoo

Nowkoo commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #28.

@Nowkoo
Nowkoo deleted the perf/studio-dirty-saves branch October 11, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant