Repository navigation
fix(skins): keep owner skin files out of Cloudflare's cache - #217
Merged
Merged
Conversation
Cloudflare caches any path ending in .png by URL alone, so a 401 or 404
from /skins/submissions/{id}/files/{name}.png was served to the owner's
later requests for four hours. The file name is now a query parameter
(/files?name=), which Cloudflare leaves to the origin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #216. Cloudflare caches any path ending in
.pngby URL alone, so an error fromGET /skins/submissions/{id}/files/{name}.png(an expired session's 401, say) was handed to the owner's later requests for four hours, and the skin page fell back to its static picture. Seen on Dev: a test 404 came back withage: 61,cache-control: max-age=14400. The file name is now a query parameter (/files?name=), which Cloudflare passes to the origin. The drink texture route has no extension and is unaffected.Tests:
test_skin_owner_files.py, path traversal, Profile and skins frontend tests pass.🤖 Generated with Claude Code