Skip to content

Make the character selector readable - #104

Merged
ryanbarlow97 merged 2 commits into
mainfrom
select-readability
Oct 12, 2026
Merged

ryanbarlow97 merged 2 commits into
mainfrom
select-readability

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

The selector's grey and teal text sat on a bright, blurred noon sky. Readability should not depend on the client's sky, brightness, fullbright or shaders.

  • Fixed dark backdrop: the selection platform is now an enclosed 11×11×5 black-concrete box: the old 9×9 floor area plus walls and a ceiling. Black concrete stays dark even at full light. Players are already movement-locked at the spawn point. The plugin rebuilds the box on every startup, so the existing room changes after a restart.
  • Brighter palette: PALE #FFFFFF, TEAL #66F0E2, MUTED #D0DCDD, DIM #A4B0B1 and WARN #FF8F7D, keeping the existing hierarchy. Bright text relies on Minecraft's dark text shadow, as vanilla UI does.

mvn clean verify: 2167 tests, 0 failures.

Docs: TF-Minecraft/Docs#202

Set the selection room to midnight so the dialog sits on a dark sky, and
lighten the muted and dim text colours.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ece0f876-0443-4a1e-9e25-f4baa0d0c0fa
📥 Commits

Reviewing files that changed from the base of the PR and between d1640e6 and 3bb3da2.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectView.java
  • src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectionWorld.java
  • src/test/java/net/tfminecraft/rpcharacters/body/CharacterSelectionWorldTest.java

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 50ec7ab3-56f9-40b1-ac67-673ead617628
📥 Commits

Reviewing files that changed from the base of the PR and between 2a13ffb and d1640e6.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectView.java
  • src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectionWorld.java
  • src/test/java/net/tfminecraft/rpcharacters/body/CharacterSelectionWorldTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Style
    • Lightened muted and dim text colours for improved readability.
  • Visual Updates
    • Changed the character selection screen’s background to midnight, keeping the sky dark behind the dialogue.

Walkthrough

The character selection view now uses lighter MUTED and DIM text colours. The selection world is created at time 18000, and its test expects the updated time.

Changes

Character selection visuals

Layer / File(s) Summary
Update selection text colours
src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectView.java
The MUTED colour changes to 0xB4C4C6. The DIM colour changes to 0x8E9EA0.
Set selection world time
src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectionWorld.java, src/test/java/net/tfminecraft/rpcharacters/body/CharacterSelectionWorldTest.java
World creation sets the time to 18000. The test expects this value; its spawn-location and save checks remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d1640

The selection world remains at midnight during use, and no material issue with the visual updates is established. The change is mergeable with normal checks.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97

Copy link
Copy Markdown
Contributor Author

Docs: TF-Minecraft/Docs#202

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 12, 2026
Enclose the selection platform in black concrete instead of relying on
the sky, which fullbright, shaders and custom skies change, and use a
brighter palette that reads on any background.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added size:S 10-29 effective changed lines (tests excluded in mixed PRs). and removed size:XS 0-9 effective changed lines (tests excluded in mixed PRs). labels Oct 12, 2026
@ryanbarlow97
ryanbarlow97 merged commit f18fd86 into main Oct 12, 2026
3 checks passed
@ryanbarlow97
ryanbarlow97 deleted the select-readability branch October 12, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant