Repository navigation
Make the character selector readable - #104
Conversation
Set the selection room to midnight so the dialog sits on a dark sky, and lighten the muted and dim text colours. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to The selection world remains at midnight during use, and no material issue with the visual updates is established. The change is mergeable with normal checks.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Docs: TF-Minecraft/Docs#202 |
Enclose the selection platform in black concrete instead of relying on the sky, which fullbright, shaders and custom skies change, and use a brighter palette that reads on any background. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The selector's grey and teal text sat on a bright, blurred noon sky. Readability should not depend on the client's sky, brightness, fullbright or shaders.
#FFFFFF, TEAL#66F0E2, MUTED#D0DCDD, DIM#A4B0B1and WARN#FF8F7D, keeping the existing hierarchy. Bright text relies on Minecraft's dark text shadow, as vanilla UI does.mvn clean verify: 2167 tests, 0 failures.Docs: TF-Minecraft/Docs#202