Skip to content

Hide the room body in third person - #106

Merged
ryanbarlow97 merged 2 commits into
mainfrom
select-invisible
Oct 12, 2026
Merged

Hide the room body in third person#106
ryanbarlow97 merged 2 commits into
mainfrom
select-invisible

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

In the selection room, F5 showed the player's own Steve body.

  • After entering the room, players get infinite invisibility with no particles, icon or ambient effect. F5 then shows nothing, since the cleared player wears no armour and holds no items.
  • On Play, the invisibility is removed just before the character's body is applied, and the body snapshot applies its own effects as before. Stowing a character still captures its effects before the room clears them.
  • Why not spectator mode: the server ignores container clicks from spectators, and character creation runs its inventory menus in this room. Spectator would also mean persisting and restoring game modes.

mvn clean verify passes, with a new test for apply and remove ordering.

@ryanbarlow97
Hide the room body in third person
06004f2 
Give selecting players a hidden infinite invisibility effect so F5 shows
no body. The selected character's own effects replace it on Play.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4e53fce4-1134-456b-8aa2-bdd108e60f00
📥 Commits

Reviewing files that changed from the base of the PR and between f18fd86 and a87735a.

📒 Files selected for processing (2)
  • src/main/java/net/tfminecraft/rpcharacters/body/CharacterBodies.java
  • src/test/java/net/tfminecraft/rpcharacters/body/CharacterBodiesTest.java
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97 ryanbarlow97 mentioned this pull request Oct 12, 2026
Merged
@ryanbarlow97

ryanbarlow97 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Docs: TF-Minecraft/Docs#204

@ryanbarlow97
Renew room invisibility and hide on room clear
a87735a 
Hide the body when the room clears it, so pack waits are covered. Use a
finite effect renewed by the checkpoint, so saved data cannot keep it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ryanbarlow97
ryanbarlow97 merged commit 30db444 into main Oct 12, 2026
3 checks passed
@ryanbarlow97
ryanbarlow97 deleted the select-invisible branch October 12, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ryanbarlow97