Skip to content

Drop last location from the Play tooltip - #107

Merged
ryanbarlow97 merged 1 commit into
mainfrom
select-no-location
Oct 12, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
select-no-location

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

The Play tooltip no longer shows the character's last location. It now lists birthday, playtime, pouch and bank. mvn clean verify passes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 12, 2026
@ryanbarlow97

Copy link
Copy Markdown
Contributor Author

Docs: TF-Minecraft/Docs#205

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c44a18fe-052e-4b0b-b3f1-8ac567972a20
📥 Commits

Reviewing files that changed from the base of the PR and between 30db444 and 89ea13c.

📒 Files selected for processing (2)
  • src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectView.java
  • src/test/java/net/tfminecraft/rpcharacters/body/CharacterSelectViewTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Updates
    • Character cards no longer display a character’s last-known world or coordinates. Birthday, playtime and available balances remain visible.
    • The play-button tooltip no longer shows last-location information.

Walkthrough

The character selector details tooltip no longer displays a character’s last-location world or coordinates. The selector test removes the related location stubs and expected tooltip line.

Changes

Character selector tooltip

Layer / File(s) Summary
Update tooltip details and test
src/main/java/net/tfminecraft/rpcharacters/body/CharacterSelectView.java, src/test/java/net/tfminecraft/rpcharacters/body/CharacterSelectViewTest.java
The details tooltip retains birthday, playtime and available balances, but no longer includes the last-location world or floored coordinates. The test no longer supplies location data or expects a last-location line.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 89ea1

The Play tooltip will no longer show last-location details, while other systems retain that data. No repository requirement for the removed tooltip content was found, so no actionable merge-blocking risk is established.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit 802fc42 into main Oct 12, 2026
3 checks passed
@ryanbarlow97
ryanbarlow97 deleted the select-no-location branch October 12, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant