Repository navigation
Make faction members characters - #160
Merged
Merged
Conversation
Council seats, refusals, election candidates and votes, session voters, movement and cause leaders, pool citizens and proposal proposers and targets are member keys: matched exactly, shown by character name and turned into players through Members. Movement admin commands take character names with spaces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member strings in the war, raid, civil war and request code are now character member keys. Combat state stays keyed by account; warband rejoin waits for the same character's session to start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Menus, creators and tab completion use member keys: lookups by the current character, names shown through Members, heads from the account that plays the character. Plugin menus capture the opener's character session and close with a short message when clicked after a switch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Vehicles, mercenaries, espionage, inactivity, prestige, chat resolvers, ledger and utils use member keys. Mercenary eligibility reads the enrolled character's own trait. CharacterNames gives way to Members. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 381 files, which is 281 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
📒 Files selected for processing (381)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size:XXL
This was referenced Oct 12, 2026
ryanbarlow97
marked this pull request as ready for review
October 12, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 5 makes SimpleFactions character-based end to end: guild membership, leadership, voting, mercenary enrollment, treasuries, daily settlement, vehicles and death succession all follow characters instead of Minecraft accounts.
SimpleFactionsApi.ready()or the ready event before loading faction state.guild:<incarnation UUID>accounts (signed debt preserved); citizen tax is withheld toguildtax:<incarnation>and swept in settlement. One immutable realm-wide plan pays each day as a singlesf:settle:<day>posting with exact replayable effects; recovery never recalculates a published day.deathIdbefore rights cleanup and succession; vehicle payers migrate once from VehicleFramework's persisted ownership to heir characters.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verify: 7,799 tests, no failures, 100% line coverage gate passed (f5149ad).Draft integration branch for stage 5 of TF-Minecraft/RPCharacters#89 and #156. Documentation: TF-Minecraft/Docs#199. This must ship as one coordinated set with TLibs, DenarEconomy, RPCharacters and the migrated consumers; no release or server deployment is included.