Repository navigation
Find living characters by real name - #45
Conversation
Add CharacterIdentity.findByName, a default method returning an empty immutable list, and the matching Characters.findByName facade method. Providers match canonical real names of living characters, ignoring case; masks and aliases never match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
|
Muse (independent reviewer) reviewed this PR after merge, against the stage 6a design: verdict OK. Two minor notes, neither a release risk: |
Adds
CharacterIdentity.findByName(String) -> List<CharacterInfo>and the matchingCharacters.findByName(String)facade method, for stage 6a's typed-name vehicle whitelist.CharacterInfo.name(), no masks or aliases) equals the argument, ignoring case. Several characters can share a name, so the result can hold more than one.Consumers that need this (VehicleFramework's typed-name whitelist) probe for it and disable the feature without TLibs 2.5.0.
Intended release: TLibs 2.5.0 (not tagged; installed locally only for the dependent builds).
Gate:
tfmc-mvn -o -B clean verify, 206 tests, 0 failures, JaCoCo line gate (0 missed lines) met.Docs: TF-Minecraft/Docs#207
Implementation: TF-Minecraft/RPCharacters#108
🤖 Generated with Claude Code