Feature/expose bandwidth estimates - #892
Draft
wvanhaevre wants to merge 7 commits into
Draft
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
1519
to
1521
| - THEOplayer-Integration-THEOads (~> 11.4) | ||
| - THEOplayer-Integration-THEOlive (~> 11.4) | ||
| - THEOplayerSDK-core (~> 11.4) |
Collaborator
There was a problem hiding this comment.
@wvanhaevre Would it make sense to run pod install in example/ios to update the lock with the updated dependency in the podspec?
Collaborator
There was a problem hiding this comment.
There seem two be 3 naming conventions
| Family | Examples |
|---|---|
| THEOplayer{Native,Web}Adapter | THEOplayerNativeAdsAdapter/THEOplayerWebAdsAdapter, THEOplayerNativeCastAdapter/THEOplayerWebCastAdapter |
| {Native,Web}Adapter | TheoLiveNativeAdapter/TheoLiveWebAdapter, MediaControlNativeAdapter/MediaControlWebAdapter, THEOAdsNativeAdapter/THEOAdsWebAdapter |
| Adapter, no platform marker | AbrAdapter, TextTrackStyleAdapter — both native-only, with no web counterpart |
The two new MetricsAdapters have been named using different conventions. I would suggest either:
- renaming
MetricsAdaptertoMetricsNativeAdapterandTHEOplayerWebMetricsAdaptertoMetricsWebAdapter
or - renaming
MetricsAdaptertoTHEOplayerNativeMetricsAdapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
MetricsAPI, accessible throughplayer.metrics, withcurrentBandwidthEstimatereturning the player's estimated available bandwidth in bits per second. On iOS/tvOS this value is only reported for THEOlive/HESP streams.Depends on unreleased iOS Native 11.8.0