Skip to content

Unmute player when interacting with volume slider - #171

Merged
ceyhun-o merged 3 commits into
mainfrom
bugfix/volume-slider-mute-state
Aug 10, 2026
Merged

Unmute player when interacting with volume slider#171
ceyhun-o merged 3 commits into
mainfrom
bugfix/volume-slider-mute-state

Conversation

@ceyhun-o

@ceyhun-o ceyhun-o commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

This PR adds 2 small changes:

  • When the player is muted, the volume bar now reflects the minimum value (goes all the way to 0).
  • When the player is muted, clicking to set a different volume on the volume bar or dragging it now unmutes the player.

Both of these were the behavior of the old VJS based UI.

The only different case still not handled is:

  • When the player is muted (and thus volume bar shows 0), if you just click on the volume bar at where it is (meaning, if you also click on its 0 volume position), the player doesn't unmute with the 0 volume. VJS-based UI is doing this but I don't believe this is necessary?

Closes #120.

@ceyhun-o ceyhun-o added the enhancement New feature or request label Aug 10, 2026
@changeset-bot

changeset-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8d17c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@theoplayer/web-ui Patch
@theoplayer/react-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ceyhun-o
ceyhun-o merged commit ee0a072 into main Aug 10, 2026
1 check passed
@ceyhun-o
ceyhun-o deleted the bugfix/volume-slider-mute-state branch August 10, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interacting with volume slider doesn't unmute the player

2 participants