Repository navigation
fix(backup): say what each engine's restore keeps in its confirmation - #3984
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
November 1, 2026 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlite3 -bailstops at the first error, and a backup TablePro wrote is one transaction, so none of it is kept. A dump that is not one transaction keeps what ran before the error. The sheet used to say existing objects are kept and the dump's data added.mysqlruns without--force) and keeps what ran before it, and that a TablePro backup overwrites each object it names.apple/scripts/probes/check-restore-error-semantics.shchecks these facts againstsqlite3, the mysql family andpg_restore.RestoreConfirmationTextTests.appendingEnginesKeepExistingObjectspinned SQLite to the old text; it now covers PostgreSQL, Redshift and MongoDB only, and SQLite and MySQL get their own cases.Docs: TableProApp/docs#162
Test plan
RestoreConfirmationTextTests:sqliteStopsAtTheFirstErrorandmySQLStopsAtTheFirstErrorfail on main.-bailremoved, the SQLite checks fail.