Repository navigation
fix: split the script-tester and product-CI meanings of continuous-integration.yml - #27
Merged
Merged
Conversation
…tegration.yml The scaffolding scripts' own test runner and a leaf's real build/test/pack pipeline both wanted the path .github/workflows/continuous-integration.yml, which is the leaf's forever-conflict on every template-sync. Rename the script-tester back to test-scripts.yml and reserve continuous-integration.yml exclusively for a repo's own product pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A1 from the final review
.github/workflows/continuous-integration.ymlcarried two different jobsunder one name:
template layer, deleted for a Code-kind leaf since it has no
scripts/.repo, and the thing
draft-release/fetch-release-artifactsexpect tofind artifacts from.
Every leaf that authors its own real CI (starting with
.actions) collideswith the template on that same path on every sync - the third item in the
"forever-conflict" set alongside
README.mdandsettings.yml, and this onewas self-inflicted by an earlier rename.
Renames the script-tester back to
test-scripts.yml, freeingcontinuous-integration.ymlto mean only "this repo's own productpipeline" everywhere. Also removes the latent ambiguity in
fetch-release-artifacts/draft-release'sbuild-workflowdefault(
Continuous Integration) - no code change needed there, it just stopsbeing ambiguous.
Updated: the workflow file itself,
Remove-ScriptsFolder(
New-Repo-Files.psm1, still deletes the right file for a Code-kind leaf),its test, the
README.mdtable,scripts/README.md, thetemplate-syncskill's ownership list, anddocs/TemplateChain.md'sauthoritative ownership list.
Full suite: 599 passed, 0 failed.