Skip to content

fix(create): AI chat sample threadId and drop empty pnpm key #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jherr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(create): AI chat sample threadId and drop empty pnpm key #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/ai-threadid-and-empty-pnpm-key.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@tanstack/create': patch
---

fix(create): make AI add-on chat sample work out of the box and drop the empty `pnpm` key

- The AI add-on's chat hook now passes the required `threadId` to `useChat`, so the generated sample runs without manual fixing.
- Removed the empty `"pnpm": {}` key from the React and Solid base templates so generated projects no longer carry an invalid, empty `pnpm` field. Add-ons that need `pnpm.onlyBuiltDependencies` still inject it.
3 changes: 2 additions & 1 deletion packages/create/src/frameworks/react/add-ons/ai/assets/src/lib/demo-ai-hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ const chatOptions = createChatClientOptions({

export type ChatMessages = InferChatMessages<typeof chatOptions>

export const useGuitarRecommendationChat = () => useChat(chatOptions)
export const useGuitarRecommendationChat = () =>
useChat({ ...chatOptions, threadId: 'guitar-recommendations' })
3 changes: 1 addition & 2 deletions packages/create/src/frameworks/react/project/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@
"react": "^19.2.0",
"react-dom": "^19.2.0"
},
"devDependencies": {},
"pnpm": {}
"devDependencies": {}
}
3 changes: 1 addition & 2 deletions packages/create/src/frameworks/solid/project/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@
"@tanstack/solid-start": "latest",
"solid-js": "^1.9.12"
},
"devDependencies": {},
"pnpm": {}
"devDependencies": {}
}
Loading