fix: treat conditional skips as successful runs - #2650
Draft
Mbeaulne wants to merge 1 commit into
Draft
Conversation
🎩 PreviewA preview build has been created at: |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Updates the aggregate run status shown in the runs list for pipelines with conditional execution.
Tangle currently assigns
SKIPPEDonly to a task whoseisEnabledcondition resolves to false and to tasks downstream of that conditionally skipped task. A successful run can therefore contain bothSUCCEEDEDandSKIPPEDtask counts.This PR changes the terminal status priority so that:
SUCCEEDEDwith conditionally skipped tasks is displayed as Succeeded.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Not applicable.
Test Instructions
false.Automated checks:
Additional Comments
The runs-list API returns aggregate status counts rather than task-level skip reasons. This behavior relies on the current Tangle contract that
SKIPPEDis only produced by conditional execution and its downstream propagation. If another skip reason is introduced, the backend should expose distinct skip reasons or an authoritative overall run status.