XeTeX: preserve filedump offsets beyond 16 bits - #89
Open
IvanaGyro wants to merge 2 commits into
Open
Conversation
Add a filedump fixture with sentinel bytes around the 16-bit offset boundary, along with EOF and invalid range cases. This exposes the current offset truncation. Assisted-by: Codex
The conversion routine stored the scanned offset in small_number, truncating values at the 16-bit boundary before getfiledump() saw them. Store it in integer, matching the helper's offset parameter. Fixes: TeX-Live#88 Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88.
XeTeX stored the parsed
\\filedumpoffset insmall_number, truncatingvalues at the 16-bit boundary before
getfiledumpreceived them. Store theoffset in
integer, matching the helper's argument type.The first commit adds a regression fixture with sentinel bytes around the
16-bit boundary, together with EOF and invalid-argument cases. The second
commit contains the one-line fix.
Tested:
make xetexxetex-filedump.test