Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
NotificationControllerAPI 6개의 애플리케이션 계층 요청 위임과 HTTP 응답을 단위 테스트로 검증했습니다.GET /notifications/unread,POST /notifications/{notificationId}/read도 대체 API 안내와 함께 문서화하고 OpenAPI에deprecated: true로 표시했습니다.feedId와novelId의 nullable 이동 계약을 OpenAPI 스키마에 반영했습니다.code로 분기하도록 Swagger에 안내했습니다.Test
./gradlew test --tests org.websoso.WSSServer.notification.controller.NotificationControllerTest --tests org.websoso.WSSServer.notification.controller.notification.NotificationDocsTest./gradlew apiDocs두 명령 모두 로컬에서 성공했습니다. 생성된
build/api-spec/openapi3.json에서 6개 경로, Deprecated 표시, 작품 알림 예시, nullable 스키마, 전체 오류 응답 named example을 확인했습니다.To Reviewers
201 Created, 신규 API는204 No Content를 반환하는 차이를 각각 문서에 유지했습니다.POST /notifications/{notificationId}/read에는@Positive검증이 없어 경로 파라미터에 양수 제약을 표기하지 않았습니다.build/아래에서 생성하며 커밋하지 않습니다.References