Skip to content

Build improvements - #4728

Open
TranceLove wants to merge 2 commits into
hotfix/3.11.3from
feature/build-improvements-redux
Open

TranceLove wants to merge 2 commits into
hotfix/3.11.3from
feature/build-improvements-redux

Conversation

@TranceLove

@TranceLove TranceLove commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Please install NDK 30 (30.0.16248370) before running the build locally.

Changes:

  • Pin Rust version to 1.98.1 at Github Actions
  • Add rust-toolchain.toml to pin Rust version on local builds
  • Github Action use JDK 21
  • Bump NDK version to r30 LTS
  • Make JDK version specification controllable from libs.versions.toml
  • Github Actions workflow files align with release/4.0 branch for latest versions of Github Actions and syntaxes

Issue tracker

Fixes #4551 (hopefully)

Automatic tests

N/A

Manual tests

  • Done

  • Device:

  • OS:

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

Generative code

  • This PR used generative code tools (GenAI, LLMs, etc.)

AI was used in pointing out the use of Rust toolchain overrides rust-toolchain.toml during research.

@TranceLove TranceLove added Area-CICD Issues related to CI/CD. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Sep 24, 2026
@TranceLove
TranceLove marked this pull request as draft September 24, 2026 10:37
@TranceLove
TranceLove force-pushed the feature/build-improvements-redux branch 5 times, most recently from 82c0dc5 to 7f8a840 Compare September 24, 2026 13:55
- Pin Rust version to 1.98.1 at Github Actions
- Add rust-toolchain.toml to pin Rust version on local builds
- Github Action use JDK 21
- Bump NDK version to r30 LTS
- Bump Github Action versions and align arguments with reference from release/4.0 branch
@TranceLove
TranceLove force-pushed the feature/build-improvements-redux branch from 7f8a840 to 7b70869 Compare September 24, 2026 15:28
@TranceLove
TranceLove marked this pull request as ready for review September 24, 2026 15:59
@TranceLove TranceLove self-assigned this Sep 24, 2026
@TranceLove

Copy link
Copy Markdown
Collaborator Author

@IzzySoft please see if it helps

@EmmanuelMess EmmanuelMess added PR-No-App-Changes this PR doesn't change any Amaze app code, but does change code PR-Code-Review-Passed The human code review has passed for this PR. labels Sep 26, 2026

@EmmanuelMess EmmanuelMess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really needs a clear way to inform the developer that the NDK version is not the one expected, especially if it needs an exact match. The error message from compilation is really not helpful, as it tells you the NDK library is missing altogether.

@IzzySoft

Copy link
Copy Markdown
Contributor

please see if it helps

thanks! But with ~1k apps in our builder, I cannot remember all details for each app 🙈 So I first need to figure out "helps with what exactly… Ah, issue linked, thanks!

  • we could pick versions for JDK, NDK, from gradle/libs.versions.toml
  • I was about to say rust setup could now be automated thanks to your rust-toolchains.toml – but I doubt it will be found in the sub directory. Doesn't rustup expect that in the project root, or the current working directory? OK, guess we could first cd into file_operations I guess. Ah, I see we do that already, to call setup_rust_android.sh.

Guess we'll have to see if the cargo error is gone with the next release then, after this PR has been merged…

Add check for NDK and NDK version in setup_rust_android.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CICD Issues related to CI/CD. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. PR-Code-Review-Passed The human code review has passed for this PR. PR-No-App-Changes this PR doesn't change any Amaze app code, but does change code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants