Build improvements - #4728
Open
TranceLove wants to merge 2 commits into
Open
Build improvements#4728TranceLove wants to merge 2 commits into
TranceLove wants to merge 2 commits into
Conversation
TranceLove
marked this pull request as draft
September 24, 2026 10:37
TranceLove
force-pushed
the
feature/build-improvements-redux
branch
5 times, most recently
from
September 24, 2026 13:55
82c0dc5 to
7f8a840
Compare
- Pin Rust version to 1.98.1 at Github Actions - Add rust-toolchain.toml to pin Rust version on local builds - Github Action use JDK 21 - Bump NDK version to r30 LTS - Bump Github Action versions and align arguments with reference from release/4.0 branch
TranceLove
force-pushed
the
feature/build-improvements-redux
branch
from
September 24, 2026 15:28
7f8a840 to
7b70869
Compare
TranceLove
marked this pull request as ready for review
September 24, 2026 15:59
Collaborator
Author
|
@IzzySoft please see if it helps |
EmmanuelMess
requested changes
Sep 26, 2026
EmmanuelMess
left a comment
Member
There was a problem hiding this comment.
This really needs a clear way to inform the developer that the NDK version is not the one expected, especially if it needs an exact match. The error message from compilation is really not helpful, as it tells you the NDK library is missing altogether.
Contributor
thanks! But with ~1k apps in our builder, I cannot remember all details for each app 🙈 So I first need to figure out "helps with what exactly… Ah, issue linked, thanks!
Guess we'll have to see if the cargo error is gone with the next release then, after this PR has been merged… |
Add check for NDK and NDK version in setup_rust_android.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please install NDK 30 (
30.0.16248370) before running the build locally.Changes:
rust-toolchain.tomlto pin Rust version on local buildslibs.versions.tomlrelease/4.0branch for latest versions of Github Actions and syntaxesIssue tracker
Fixes #4551 (hopefully)
Automatic tests
N/A
Manual tests
Done
Device:
OS:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheckGenerative code
AI was used in pointing out the use of Rust toolchain overrides
rust-toolchain.tomlduring research.