Conversation
10 tasks
Collaborator
|
Thank you @Sthreal for fixing and validating the Windows upgrade restart issue! The issue targeted by this PR has now been addressed in #346 through a unified upgrade approach, including replacing the running version, confirming that the new daemon has taken over, and restoring the old version and service if the upgrade fails. We have also adopted the documentation note here regarding BSK_AUTO_UPDATE=off, and your co-author attribution has been retained in the commits for #346. Subsequent fixes and validation will be consolidated in #346, so we are closing this PR and marking it as superseded by #346. Thank you for your contribution, and we welcome you to continue participating in the validation and discussion of #346! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #336
What changed
CREATE_BREAKAWAY_FROM_JOB, log the failure and retry withbsk daemon start --foreground.BSK_AUTO_UPDATE=offand the Windows daemon restart fallback in the README.Why
The current update path can replace
bsk.exesuccessfully, then fail to start the replacement daemon with:The old daemon has already exited at that point, so the browser pipeline stays disconnected until the user manually starts the daemon again.
Verification
cargo test -p bsk --test windows_update -- --nocapture— 3 passedcargo test -p bsk --lib cli::update— 26 passedcargo test -p bsk --lib daemon— 147 passed / 1 ignoredcargo fmt --all -- --check— passedcargo clippy -p bsk --all-targets— passed with pre-existing warnings outside this change