Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bc75516 to
3067c42
Compare
customer-v2 "LFD in the next 3 days" answered 93 against a reference of 14: without a status filter the window includes containers already picked up or still on the water. The list_containers description and the query guidance now define next-N-day LFDs as containers still at the terminal (available, not_available, grounded) with pickup_lfd from today through N.days.from_now, keep past-due LFDs separate, and say today is the API server's UTC date. The guidance also drops recipes that contradicted the dashboard definitions (discharged-not-picked-up by milestones, demurrage risk by LFD bounds). Checked on Sodor staging: the status-limited window gives the reference 14; arrivals in 10 days give 34. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3067c42 to
1bca2ee
Compare
The force-push that rebased this branch onto main made the Postman workflow compare against the old stacked base, which saw openapi.json changes and regenerated the collection. That regeneration only reshuffled generated IDs and example values. This branch does not change the spec, so it keeps main's collection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Rebased the single commit onto The force-push made the Postman workflow compare against the old base, so When merging: b99d26d's message contains Local on the rebased branch: |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Shadow risk calibration
Calibration result: disagreement (high vs medium). Shadow risk never blocks or enables merge. Keep it in observation mode until roughly 50 pull requests have human-reviewed labels, then calibrate before considering any policy use. |
Resolve the list_containers description conflict by keeping this branch's LFD and arrival window sentence and main's new result-shape sentence. Regenerate the tools/list snapshot from the merged server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8cPhktNpguVMk39bAstza
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f30c259e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'Like the dashboard, only actively tracked containers are returned unless include_stopped_tracking is true (use it for history such as pickups or dwell over a past period). ' + | ||
| 'Use the dashboard definitions and report meta.total for that set before any narrowing: ready for pickup = current_status available; at risk of demurrage or needs attention = requires_attention true with sort attention_priority (the Containers at Risk view); discharged but not picked up = current_status available,not_available,grounded,awaiting_inland_transfer. ' + | ||
| 'Add extra conditions such as LFD windows, fees or holds only when the user asks, and present them as a subset of that total. ' + | ||
| 'LFD in the next N days means containers still at the terminal: current_status available,not_available,grounded with pickup_lfd [">=today", "<=N.days.from_now"]; LFDs already past are separate (pickup_lfd "<today"). Arriving in the next N days: arrival [">=today", "<=N.days.from_now"]. "Next N days" includes today and day N; today is the API server\'s UTC date, so state the dates you used. ' + |
There was a problem hiding this comment.
Keep terminal status scope for past-due LFDs
When a user asks for past-due LFDs, this recipe specifies only pickup_lfd < today, even though active tracking does not exclude picked-up or in-transit containers whose historical LFD remains populated. Those records can therefore inflate what should be an actionable terminal worklist—the same failure mode the preceding next-N-days recipe avoids. Apply the terminal current_status restriction to the past-due recipe as well, or direct the model to the appropriate dashboard attention predicate.
Useful? React with 👍 / 👎.
Targets
main. Originally stacked on #404, which closed unmerged; its dashboard definitions reachedmainseparately, so this is now the single commit rebased ontomain.Why
customer-v2 lfd-next-3-days ("Which containers have a last free day in the next 3 days?") answered 93 against a reference of 14. On Sodor staging:
pickup_lfdtoday → +3 days, no status filter (what the agent did)current_status=available,not_available,groundedpickup_lfd <today)arrivaltoday → +10 daysThe query-guidance resource also contradicted #398's definitions: it described "discharged but not picked up" as
pod_discharged_at @exists+picked_up_at @not_exists, and demurrage risk as LFD bounds instead of the Containers at Risk set.What
list_containersdescription: next-N-day LFD = still at the terminal +pickup_lfd [">=today", "<=N.days.from_now"]; past-due is separate; arrivals usearrivalwith the same bounds; "next N days" includes today and day N;todayis the API server's UTC date (relative and absolute dates differ after midnight UTC: 11 vs 14 when I checked), so the agent states the dates it used.terminal49://docs/mcp-query-guidance: same definitions; drops the contradicting recipes.Tests
MCP 445 passed on current
main(2 new).vp run checkandvp run buildpass.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.

Confidence Score: 5/5
This PR appears safe to merge.Summary
Aligns MCP query guidance with the dashboard definitions.
No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "chore: restore main's Postman collection" · Reviewed by Greptile