Skip to content

fix: clear the directory's credential hold (0.3.3) - #19

Merged
dodeja merged 1 commit into
mainfrom
claude/eager-mendel-3x7b4e
Nov 7, 2026
Merged

dodeja merged 1 commit into
mainfrom
claude/eager-mendel-3x7b4e

Conversation

@dodeja

@dodeja dodeja commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Summary

The Anthropic directory held 0.3.2 with MCP_FORWARDS_CREDENTIAL_ENV ("Uses a credential from the user's machine"). The plugin reads no credential. Its only MCP server is https://mcp.terminal49.com, it signs in with OAuth, and it sets no env or headers. The finding points only at plugin.json, so the trigger is a best guess:

  • evals/mocks/terminal49/_tools.json carried the whoami output schema. That schema lists credential_name and credential_type, with the values api_key and shared_token, inside the same plugin as the MCP server. The checker flagged this file once before for credential-named fields.
  • evals/check-delta.mjs shipped a Node script in the plugin folder, which contradicts the README.

Changes

  • Strip outputSchema from the eval mock and from its refresh command. The evals use only tool descriptions and input schemas.
  • Move evals/check-delta.mjs to scripts/check-eval-delta.mjs.
  • scripts/validate.mjs now rejects script files in the plugin folder and outputSchema in eval mocks.
  • Bump every manifest and marketplace entry to 0.3.3.

The eval folder stays inside the plugin, because claude plugin eval rejects an --eval-dir outside the plugin root.

Verification

  • npm run validate passes, and it reports an error when a test .mjs file is placed in the plugin folder.
  • claude plugin validate . passes.
  • A mocked eval run (--case where-is-container --runs 1 --mocks record) scores 1.00 with the trimmed mock.

After merging, submit 0.3.3 to the directory.


Generated by Claude Code


Proof this PR
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

The directory held 0.3.2 for MCP_FORWARDS_CREDENTIAL_ENV, but the plugin
reads no credential: its only MCP server is the OAuth-protected
https://mcp.terminal49.com with no env or headers. The likely trigger is
the eval tool mock, whose whoami output schema lists credential fields
(credential_type with api_key and shared_token values) next to the MCP
server, plus a Node script shipped in the plugin folder.

- Strip outputSchema from the eval mock and its refresh command. The
  evals use only tool descriptions and input schemas.
- Move evals/check-delta.mjs to scripts/check-eval-delta.mjs so the
  plugin ships no scripts, as its README states.
- Teach validate.mjs to reject scripts in the plugin folder and output
  schemas in eval mocks.
- Release 0.3.3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V8cPhja2zU4b4D1b9xHAUi
@dodeja
dodeja marked this pull request as ready for review November 7, 2026 00:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T00:36:36.731123Z 2516975 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dodeja
dodeja merged commit 0c33fd4 into main Nov 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants